Skip to content

contrib/google.golang.org/grpc: fix gen_proto.sh script#2196

Merged
rarguelloF merged 2 commits into
mainfrom
rarguelloF/update-grpc-gen-proto
Aug 31, 2023
Merged

contrib/google.golang.org/grpc: fix gen_proto.sh script#2196
rarguelloF merged 2 commits into
mainfrom
rarguelloF/update-grpc-gen-proto

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix build errors with protoc generated files (missing newlines).

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Aug 31, 2023

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-08-31 15:14:14

Comparing candidate commit 3122309 in PR branch rarguelloF/update-grpc-gen-proto with baseline commit 52975ed in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@rarguelloF
rarguelloF marked this pull request as ready for review August 31, 2023 15:00
@rarguelloF
rarguelloF requested a review from a team August 31, 2023 15:00
@rarguelloF
rarguelloF merged commit 38f30b0 into main Aug 31, 2023
@rarguelloF
rarguelloF deleted the rarguelloF/update-grpc-gen-proto branch August 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants