all: move to 1.19 for lowest supported version#2192
Merged
Conversation
Goland insisted persistently to update dependencies here.
BenchmarksBenchmark execution time: 2023-09-04 08:08:41 Comparing candidate commit 634dff5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
5 tasks
darccio
force-pushed
the
dario.castane/AIT-7944/update-supported-versions
branch
from
August 31, 2023 13:23
f614c4b to
d059ae5
Compare
Julio-Guerra
approved these changes
Aug 31, 2023
Julio-Guerra
left a comment
Julio-Guerra
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the GOEXPERIMENT vs GODEBUG update 🙏
FTR, we did another solution in https://github.com/DataDog/go-libddwaf/blob/main/.github/workflows/test.yml#L20-L25 but we're good for now, we'll align later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Go 1.21 has been out for a few weeks. Time to update! Also, dd-trace-go is officially un-compilable in <1.18 due to some dependencies introducing features only present in 1.18.
This PR is blocked by #2150 as there is a breaking change in 1.21 that could lead to issues. Just to be sure, merging this PR will occur after the former is solved.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!