Revert "ddtrace/tracer: create debug mode for old, open spans"#2183
Merged
Conversation
This reverts commit 283c0ac.
ajgajg1134
marked this pull request as ready for review
August 21, 2023 15:53
BenchmarksBenchmark execution time: 2023-08-21 16:06:37 Comparing candidate commit 0a7ade3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
darccio
approved these changes
Aug 22, 2023
Member
|
@ajgajg1134 Please, can you give a link to the failing tests? I would like to take a look to them. |
Contributor
Author
|
Sure! https://github.com/DataDog/dd-trace-go/actions/runs/5906998175/job/16072014988 here's where they failed on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2149
Unfortunately it looks like these tests are failing on
mainsporadically. An initial investigation for a bit didn't reveal the immediate cause so to unblock the build reverting this for now so we can take more time to properly determine what's going wrong here