ddtrace/tracer: fix inaccurate telemetry 'stats_computation_enabled'#2170
Merged
Conversation
darccio
approved these changes
Aug 16, 2023
igoragoli
pushed a commit
that referenced
this pull request
Sep 5, 2023
…_enabled' (#2170) Config telemetry was reporting inaccurate metric stats_computation_enabled, it was reporting whether the agent supported client-stats computation (c.agent.Stats) instead of whether the tracer was actually doing stats computation (i.e c.canComputeStats()). This commit fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Config telemetry was reporting inaccurate metric
stats_computation_enabled, it was reporting whether the agent supported client-stats computation (c.agent.Stats) instead of whether the tracer was actually doing stats computation (i.ec.canComputeStats()). This commit fixes it.Motivation
Bug fix
Reviewer's Checklist