ddtrace/tracer: Add dd.parent_id to span formatted output#2137
Merged
Conversation
ajgajg1134
marked this pull request as ready for review
July 20, 2023 20:07
BenchmarksBenchmark execution time: 2023-07-25 17:29:45 Comparing candidate commit 8c3d56e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics. |
dianashevchenko
approved these changes
Jul 25, 2023
katiehockman
pushed a commit
that referenced
this pull request
Jul 26, 2023
katiehockman
added a commit
that referenced
this pull request
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add parent_id to the span output
Motivation
Ran into a customer escalation where it would have been nice to see the parent_id directly in the logs
Describe how to test/QA your changes
unit tests should be good
No one should be relying on the structure of our debug logs for anything important
Reviewer's Checklist