tracer: add test for logging 128-bit trace ids when upper bits are empty#2101
Merged
Conversation
katiehockman
marked this pull request as ready for review
July 6, 2023 16:17
PerfectSlayer
added a commit
to DataDog/documentation
that referenced
this pull request
Jul 6, 2023
Go tracer team ensures the tracer behaves as expected here: DataDog/dd-trace-go#2101
4 tasks
rtrieu
added a commit
to DataDog/documentation
that referenced
this pull request
Jul 6, 2023
* fix: Fix DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED documentation * Update content/en/tracing/trace_collection/library_config/java.md Co-authored-by: Rosa Trieu <[email protected]> * feat: Update Go tracer documenation too Go tracer team ensures the tracer behaves as expected here: DataDog/dd-trace-go#2101 --------- Co-authored-by: Rosa Trieu <[email protected]>
knusbaum
approved these changes
Aug 3, 2023
…ce-go into katie.hockman/128-bit-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a test to verify that when
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLEDis true, the trace ID is printed as a raw integer if the upper 64-bits are 0.Motivation
Describe how to test/QA your changes
Reviewer's Checklist