contrib/emicklei/go-restful/v3: add integration for newest version#2088
Merged
Conversation
rarguelloF
requested changes
Jun 29, 2023
rarguelloF
left a comment
rarguelloF
left a comment
Contributor
There was a problem hiding this comment.
@michaelbeaumont 👋 Thanks for your contribution!
Component name needs to be updated, everything else LGTM.
Contributor
|
@michaelbeaumont there are some linter errors, could you take a look? 🙏 |
Contributor
Author
Done @rarguelloF it seems like the linter is also complaining about files in the parent directory that I didn't touch |
michaelbeaumont
force-pushed
the
feat/go-restful/v3
branch
from
June 30, 2023 16:27
2980e9f to
d6520b1
Compare
rarguelloF
approved these changes
Jul 3, 2023
expand debug log
katiehockman
approved these changes
Jul 3, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the latest version of
go-restful.Motivation
The integration for previous versions can't be used with
v3.Reviewer's Checklist