Skip to content

Updated instructions for adding a benchmark in contributing.md#2080

Merged
ahmed-mez merged 1 commit into
mainfrom
shevchenko/update-contrib-md
Jun 27, 2023
Merged

Updated instructions for adding a benchmark in contributing.md#2080
ahmed-mez merged 1 commit into
mainfrom
shevchenko/update-contrib-md

Conversation

@dianashevchenko

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR updated CONTRIBUTING.md with up-to-date instructions on adding benchmarks to CI, since they have been moved to the benchmarking-platform repository.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko
dianashevchenko requested a review from a team as a code owner June 27, 2023 12:43
ahmed-mez
ahmed-mez previously approved these changes Jun 27, 2023

@ahmed-mez ahmed-mez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pr-commenter

pr-commenter Bot commented Jun 27, 2023

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-06-27 12:54:09

Comparing candidate commit 3e2461d in PR branch shevchenko/update-contrib-md with baseline commit 9b7defb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ahmed-mez
ahmed-mez merged commit b72b941 into main Jun 27, 2023
@ahmed-mez
ahmed-mez deleted the shevchenko/update-contrib-md branch June 27, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants