tracer: discard invalid _dd.p.tid in the datadog propagator#2076
Merged
Conversation
ahmed-mez
marked this pull request as draft
June 26, 2023 17:26
ahmed-mez
force-pushed
the
ahmed/tid-validation
branch
from
June 26, 2023 17:56
9c81c9a to
bf31c4a
Compare
ahmed-mez
force-pushed
the
ahmed/tid-validation
branch
from
June 26, 2023 18:38
bf31c4a to
fa4ac80
Compare
ahmed-mez
marked this pull request as ready for review
June 26, 2023 18:52
ahmed-mez
force-pushed
the
ahmed/tid-validation
branch
from
June 27, 2023 09:50
fa4ac80 to
d183422
Compare
dianashevchenko
approved these changes
Jun 27, 2023
This was referenced Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_dd.p.tidin thedatadogpropagator if the value isn't validtidin thetracecontextpropagator: keep sending the malformedtidseems to be the expected behavior in that case, based on the parametric tests_dd.propagation_errortagMotivation
Enable test case
test_datadog_128_bit_propagation_tid_shortin parametric tests https://github.com/DataDog/system-tests/blob/main/tests/parametric/test_128_bit_traceids.py#L76Describe how to test/QA your changes
Unit tests + test case in parametric tests is enabled once this PR is merged
Reviewer's Checklist