Faster CI: Optimize Pull Request Tests#2075
Merged
felixge merged 22 commits intoJun 26, 2023
Merged
Conversation
BenchmarksBenchmark execution time: 2023-06-26 20:30:51 Comparing candidate commit 415348b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
felixge
changed the title
felixge
marked this pull request as ready for review
June 26, 2023 20:36
felixge
changed the title
| @@ -0,0 +1,31 @@ | |||
| # Composite action to upload junit test result files to Datadog CI App | |||
Member
Author
There was a problem hiding this comment.
Caught me copy & pasting, haha. Will fix.
katiehockman
approved these changes
Jun 26, 2023
felixge
deleted the
felix.geisendoerfer/PROF-7836-faster-ci-cache-gotestsum
branch
June 26, 2023 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
lintjob on "APM Large Runners" (saves up to 60s of build time, depending on scheduling)actions/checkout@v2toactions/checkout@v3and remove redundantrepositoryparameter.As the end result, this allows the "Pull Requests Tests" workflow to execute as fast as 2m45s. Even for executions where there is queuing/auto-scaling latency, I think this could bring the p95 to less than 5m.
Motivation
See
RFC: Faster CI for dd-trace-go 🚀google doc.Describe how to test/QA your changes
Reviewer's Checklist