Skip to content

ddtrace/tracer: changed default tracecontext propagation order#2072

Merged
dianashevchenko merged 9 commits into
mainfrom
shevchenko/context-propagation-order
Jul 10, 2023
Merged

ddtrace/tracer: changed default tracecontext propagation order#2072
dianashevchenko merged 9 commits into
mainfrom
shevchenko/context-propagation-order

Conversation

@dianashevchenko

@dianashevchenko dianashevchenko commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Following the issues in serverless context propagation, this PR updates the propagation order to datadog

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko
dianashevchenko requested a review from a team June 26, 2023 13:27
@dianashevchenko
dianashevchenko requested a review from a team as a code owner June 26, 2023 13:27
ahmed-mez
ahmed-mez reviewed Jun 26, 2023
View reviewed changes

@ahmed-mez ahmed-mez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just double checking, does the order matter in the extractor?

ahmed-mez
ahmed-mez reviewed Jun 26, 2023
View reviewed changes
Comment thread go.mod
@pr-commenter

pr-commenter Bot commented Jun 26, 2023 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-07-07 14:39:03

Comparing candidate commit 6ed4f12 in PR branch shevchenko/context-propagation-order with baseline commit 46268f1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics.

@ahmed-mez

ahmed-mez commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Summarizing what was discussed offline

  • It's not clear whether we want to change the order or just put datadog by default
  • The parametric tests must be implemented/fixed before making the change in the tracer

@dianashevchenko

dianashevchenko commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

Will close the PR for now

@dianashevchenko dianashevchenko changed the title Changed default tracecontext propagation order ddtrace/tracer: changed default tracecontext propagation order Jun 30, 2023
@dianashevchenko dianashevchenko mentioned this pull request Jul 7, 2023
Merged
2 tasks
@dianashevchenko
dianashevchenko merged commit eaa593d into main Jul 10, 2023
@dianashevchenko
dianashevchenko deleted the shevchenko/context-propagation-order branch July 10, 2023 17:44
katiehockman added a commit that referenced this pull request Jul 24, 2023
@katiehockman
Revert "ddtrace/tracer: changed default tracecontext propagation order (
212245f 
#2072)"

This reverts commit eaa593d.
@katiehockman katiehockman mentioned this pull request Jul 24, 2023
Merged
knusbaum added a commit that referenced this pull request Jul 25, 2023
@knusbaum
Revert "ddtrace/tracer: changed default tracecontext propagation orde…
f159c03 
…r" (cherry-pick #2140) (#2144)

Cherry-pick of #2140

We do not want to change the default context propagation at this time.

Reverts #2072
@renovate renovate Bot mentioned this pull request Aug 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsrip-dd nsrip-dd nsrip-dd left review comments
@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes
+1 more reviewer
@ahmed-mez ahmed-mez ahmed-mez left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dianashevchenko @ahmed-mez @ajgajg1134 @nsrip-dd