ddtrace/opentelemetry: improve TestSpanContextWithStartOptions#2063
Merged
Conversation
ajgajg1134
approved these changes
Jun 23, 2023
dianashevchenko
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a check to the
TestSpanContextWithStartOptionsOTel test which verifies that the payload contains two spans.Motivation
This test started failing while we were implementing partial flushing. We found that partial flushing was being triggered when it shouldn't have been, which led to the payload at the end only containing a single span, instead of 2 spans as would be expected. It took longer than necessary to realize that's why the test was failing though, so this just makes it easier to spot the root cause if this test fails in that way again.
Reviewer's Checklist