ddtrace/tracer: Fix TestSpanTracePushSeveral#2062
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2023-06-22 20:57:30 Comparing candidate commit 6b05834 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
katiehockman
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Start spans in this test instead of creating them manually.
Motivation
While working on partial flushing this test failed in weird and interesting ways because it calls finish on spans that never actually started. To avoid this, this PR actually calls start span instead of relying on the weird test function that allows creating a span directly.
Describe how to test/QA your changes
the test should continue to pass
Reviewer's Checklist