Skip to content

set a bigger timeout for the windows#2059

Merged
dianashevchenko merged 1 commit into
mainfrom
shevchenko/ci-timeout
Jun 21, 2023
Merged

set a bigger timeout for the windows#2059
dianashevchenko merged 1 commit into
mainfrom
shevchenko/ci-timeout

Conversation

@dianashevchenko

@dianashevchenko dianashevchenko commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR increases a timeout by 5 minutes for CI workflows running on Windows. Before adding more tests related to peer.service, the tests were passing at 9m37s, which was very close to failure.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko
dianashevchenko requested a review from a team as a code owner June 21, 2023 12:28
@pr-commenter

pr-commenter Bot commented Jun 21, 2023

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-06-21 12:50:40

Comparing candidate commit 2dc6e21 in PR branch shevchenko/ci-timeout with baseline commit 39472a6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@dianashevchenko
dianashevchenko force-pushed the shevchenko/ci-timeout branch from 3bfe2b5 to 71eb338 Compare June 21, 2023 12:37
@dianashevchenko
dianashevchenko changed the base branch from release-v1.52.x to main June 21, 2023 12:38
@dianashevchenko
dianashevchenko requested a review from a team June 21, 2023 12:38
ahmed-mez
ahmed-mez previously approved these changes Jun 21, 2023
@dianashevchenko
dianashevchenko merged commit d95fdb5 into main Jun 21, 2023
@dianashevchenko
dianashevchenko deleted the shevchenko/ci-timeout branch June 21, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants