Skip to content

contrib/google.golang.org/grpc: Fallback to dynamic service names if no global is found#2051

Merged
ajgajg1134 merged 2 commits into
mainfrom
andrew.glaude/GRPCToMain
Jun 20, 2023
Merged

contrib/google.golang.org/grpc: Fallback to dynamic service names if no global is found#2051
ajgajg1134 merged 2 commits into
mainfrom
andrew.glaude/GRPCToMain

Conversation

@ajgajg1134

Copy link
Copy Markdown
Contributor

What does this PR do?

Ports the patch fix to the main branch (whoops I think I did this backwards) #2048

Motivation

See linked PR

Describe how to test/QA your changes

N/A unit tested 😎

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

…no global is found (#2048)

Co-authored-by: Peter Kalmakis <[email protected]>
Co-authored-by: Katie Hockman <[email protected]>
@ajgajg1134
ajgajg1134 requested a review from a team June 15, 2023 20:06
@pr-commenter

pr-commenter Bot commented Jun 15, 2023

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2023-06-19 14:45:56

Comparing candidate commit 3eaa413 in PR branch andrew.glaude/GRPCToMain with baseline commit 61c3018 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ajgajg1134
ajgajg1134 merged commit 254acfa into main Jun 20, 2023
@ajgajg1134
ajgajg1134 deleted the andrew.glaude/GRPCToMain branch June 20, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants