tracer: fix telemetry metrics to align with spec#2049
Merged
Conversation
ajgajg1134
reviewed
Jun 15, 2023
BenchmarksBenchmark execution time: 2023-06-15 20:21:51 Comparing candidate commit de57c3e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
aditim16
approved these changes
Jun 15, 2023
ajgajg1134
approved these changes
Jun 15, 2023
katiehockman
added a commit
that referenced
this pull request
Jun 15, 2023
Changes the metrics otel.spans_created and tracer_init_time to meet the telemetry naming specification. - otel.spans_created changes to spans_created with otel as a tag instead - tracer_init_time changes to init_time, and moves to a new "general" namespace
2 tasks
dianashevchenko
pushed a commit
that referenced
this pull request
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the metrics
otel.spans_createdandtracer_init_timeto meet the telemetry naming specification.otel.spans_createdchanges tospans_createdwithotelas a tag insteadtracer_init_timechanges toinit_time, and moves to a new "general" namespaceMotivation
This is causing internal errors and triggering issues with monitors.
Describe how to test/QA your changes
Reviewer's Checklist