contrib/aws: fix sns nil pointer dereference#2025
Merged
Merged
Conversation
zARODz11z
suggested changes
Jun 9, 2023
zARODz11z
left a comment
Contributor
There was a problem hiding this comment.
Hi @satorunooshie, thank you for the contribution! Adding the phone number seems out of scope for fixing #2001 due to privacy concerns that we'd need to reevaluate further. Lets remove the addition of the phone number tag for now.
Contributor
Author
|
@zARODz11z Hello, thanks for your review. Actually I was wondering how I should handle the phone number. |
Contributor
|
@satorunooshie Thank you for the changes! That is what I was looking for. |
zARODz11z
approved these changes
Jun 12, 2023
zarirhamza
approved these changes
Jun 12, 2023
zarirhamza
left a comment
Contributor
There was a problem hiding this comment.
LGTM as well. The go tracer team should review shortly
ajgajg1134
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bugs since v1.51.0
https://github.com/aws/aws-sdk-go-v2/blob/fa15a743cc4b93dfc290d2622c92b3969ca004cf/service/sns/api_op_Publish.go#L114-L133
Motivation
Fixes #2001
Describe how to test/QA your changes
Reviewer's Checklist