contrib/gocql: add NewCluster function to trace clients#1995
Closed
rarguelloF wants to merge 10 commits into
Closed
contrib/gocql: add NewCluster function to trace clients#1995rarguelloF wants to merge 10 commits into
rarguelloF wants to merge 10 commits into
Conversation
rarguelloF
marked this pull request as ready for review
May 23, 2023 11:33
ahmed-mez
reviewed
May 31, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BenchmarksBenchmark execution time: 2023-06-19 13:48:43 Comparing candidate commit 7737493 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
rarguelloF
marked this pull request as draft
May 31, 2023 09:23
rarguelloF
changed the title
rarguelloF
marked this pull request as ready for review
June 7, 2023 10:04
ajgajg1134
requested changes
Jun 16, 2023
| telemetry.LoadIntegration(componentName) | ||
| } | ||
|
|
||
| type ClusterConfig struct { |
Contributor
There was a problem hiding this comment.
Please add godoc comments for all these new public and exported types and functions
| return tb | ||
| } | ||
|
|
||
| // WithWrapOptions allows to specify options specific to the batch. |
Contributor
There was a problem hiding this comment.
Suggested change
| // WithWrapOptions allows to specify options specific to the batch. | |
| // WithWrapOptions specifies options specific to the batch. |
| return tq | ||
| } | ||
|
|
||
| // WithWrapOptions allows to specify options specific to the query. |
Contributor
There was a problem hiding this comment.
Suggested change
| // WithWrapOptions allows to specify options specific to the query. | |
| // WithWrapOptions specifies options specific to the query. |
| require.NoError(t, err) | ||
| q := session.Query("CREATE KEYSPACE trace WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1 };") | ||
| err = q.Iter().Close() | ||
| require.Error(t, err) |
Contributor
There was a problem hiding this comment.
This requires an error?
Contributor
Author
There was a problem hiding this comment.
added IF NOT EXISTS to the query so an error is not expected require.NoError
| q := session.Query("CREATE KEYSPACE trace WITH REPLICATION = { 'class' : 'NetworkTopologyStrategy', 'datacenter1' : 1 };") | ||
| q = q.WithWrapOptions(WithResourceName("test-resource")) | ||
| err = q.Iter().Close() | ||
| require.Error(t, err) |
Contributor
Author
There was a problem hiding this comment.
did same change here
| return tq | ||
| } | ||
|
|
||
| // WithWrapOptions specifies options specific to the query. |
Contributor
There was a problem hiding this comment.
Suggested change
| // WithWrapOptions specifies options specific to the query. | |
| // WithWrapOptions applies the given set of options to the query. |
| return tb | ||
| } | ||
|
|
||
| // WithWrapOptions specifies options specific to the batch. |
Contributor
There was a problem hiding this comment.
similar here, applies the given set of options to the
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
db.cassandra.contact.pointstocontrib/gocql.gocqltrace.NewClustermethod to wrap the Cassandra client since it's created instead of individual queries.WrapQueryandWrapBatchin favor of the newNewClustermethod.db.cassandra.contact.pointstag for clients traced withNewCluster.Motivation
We want to be able to tag
db.cassandra.contact.points(and probably other stuff from the config in the future). With the current way of tracing this integration (WrapQueryandWrapBatch), we don't have access to the information that was specified during the client initialization unless we use reflection, that we should avoid.Describe how to test/QA your changes
Reviewer's Checklist