tracer: request Headers as tags for web integrations#1764
Merged
Conversation
BenchmarksBenchmark execution time: 2023-06-14 20:16:17 Comparing candidate commit 2832549 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 0 unstable metrics. scenario:BenchmarkConcurrentTracing-24
|
…s for gin integration.
…-go into mtoff/trace_header_tags
…was missing on v5)
mtoffl01
commented
Mar 6, 2023
mtoffl01
commented
Mar 6, 2023
mtoffl01
commented
Mar 6, 2023
mtoffl01
commented
Mar 7, 2023
katiehockman
reviewed
Mar 7, 2023
katiehockman
left a comment
katiehockman
left a comment
Contributor
There was a problem hiding this comment.
We should double check that we don't need to do anything with the Header name normalization which is described in the design doc.
remove extra empty line Co-authored-by: Katie Hockman <[email protected]>
…-go into mtoff/trace_header_tags
simplify headertagsfromrequest logic Co-authored-by: Katie Hockman <[email protected]>
…-go into mtoff/trace_header_tags
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mtoffl01
commented
Jun 8, 2023
mtoffl01
commented
Jun 15, 2023
mtoffl01
commented
Jun 15, 2023
katiehockman
left a comment
katiehockman
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Only thing I'm concerned by is that this changes service names. Maybe there was a bad rebase or something
TestHeaderTags becomes TestHeaderTag Co-authored-by: Katie Hockman <[email protected]>
katiehockman
previously approved these changes
Jun 15, 2023
katiehockman
left a comment
katiehockman
left a comment
Contributor
There was a problem hiding this comment.
LGTM aside from that last comment
katiehockman
approved these changes
Jun 15, 2023
Julio-Guerra
approved these changes
Jun 15, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes it possible to set request headers as tags at the integration level and at the global tracer level.
Motivation
Feature parity between tracers
Reviewer's Checklist
Triagemilestone is set.