profiler: implement profile_seq tag#1391
Merged
Merged
Conversation
nsrip-dd
approved these changes
Jul 18, 2022
nsrip-dd
left a comment
nsrip-dd
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks Felix! Nothing to change, just a small comment on some future refactoring we could do.
| } | ||
|
|
||
| func TestAllUploaded(t *testing.T) { | ||
| type profileMeta struct { |
Contributor
There was a problem hiding this comment.
Good call on this structure 👍
Idea for a future refactor (out of scope for this PR): Now TestAllUploaded and TestCorrectTags have basically the same structure, and in fact I've realized these tests are very similar to the ones in upload_test.go. I think we can pull out the server handler from this test and reuse it, and possibly get rid of most of the code in upload_test.go since a lot of what those tests cover is now covered by these integration-style tests.
Member
Author
There was a problem hiding this comment.
Good idea. I think I'll try this after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE; but please do review. See PROF-5612 for details.
Add a new
profile_seqtag that starts at 0 and is incremented by 1 for every batch.