contrib: support tracing for GraphQL#1380
Merged
Merged
Conversation
This change adds basic support for tracing GraphQL functions that use github.com/99designs/gqlgen. Query and mutation operations can be traced, with child spans generated for reading, parsing, and validating operation strings. Support for subscriptions is limited to mutations that occur within the context of a subscription, since many subscription operations are long running (e.g. a trace would remain open the entire time a client is subscribed to an endpoint). Support for field operations is not supported. Updates #507
ajgajg1134
requested changes
Jul 14, 2022
ajgajg1134
left a comment
ajgajg1134
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good so far! Just a few questions / nits here and there
Co-authored-by: Andrew Glaude <[email protected]>
ajgajg1134
previously approved these changes
Aug 3, 2022
mabdinur
reviewed
Aug 5, 2022
ajgajg1134
previously approved these changes
Aug 5, 2022
ajgajg1134
approved these changes
Aug 5, 2022
mabdinur
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds basic support for tracing
GraphQL functions that use github.com/99designs/gqlgen.
Query and mutation operations can be traced, with child
spans generated for reading, parsing, and validating
operation strings.
Support for subscriptions is limited to mutations that
occur within the context of a subscription, since
many subscription operations are long running (e.g. a trace
would remain open the entire time a client is subscribed to
an endpoint).
Support for field operations is not supported.
Updates #507