contrib/database/sql: Add WithErrorCheck options#1315
Merged
ajgajg1134 merged 14 commits intoAug 29, 2022
Conversation
soh335
marked this pull request as draft
June 1, 2022 08:34
WithErrorCheck specifies a function fn which determines whether the passed error should be marked as an error. The fn is called whenever a database/sql operation finishes with an error. close DataDog#1314
soh335
force-pushed
the
v1-contrib-db-sql-error-with-check
branch
from
June 2, 2022 01:19
c70478d to
be59f6b
Compare
soh335
marked this pull request as ready for review
June 2, 2022 06:55
gbbr
reviewed
Jun 2, 2022
gbbr
reviewed
Jun 2, 2022
gbbr
reviewed
Jun 2, 2022
Co-authored-by: Gabriel Aszalos <[email protected]>
Co-authored-by: Gabriel Aszalos <[email protected]>
gbbr
reviewed
Jun 2, 2022
Co-authored-by: Gabriel Aszalos <[email protected]>
gbbr
reviewed
Jun 2, 2022
gbbr
reviewed
Jun 2, 2022
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Sorry, last comment, promise! 🤞🏻
Co-authored-by: Gabriel Aszalos <[email protected]>
gbbr
reviewed
Jun 2, 2022
gbbr
previously approved these changes
Jun 3, 2022
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Great! LGTM! Thanks for your patience!
gbbr
approved these changes
Jul 14, 2022
Contributor
Author
|
how about ? @gbbr @katiehockman |
soh335
requested review from
gbbr and
katiehockman
and removed request for
gbbr and
katiehockman
August 24, 2022 03:13
Contributor
Author
|
@gbbr @katiehockman merged main branch. please re-review it. or can i help something to merge it ? |
ajgajg1134
approved these changes
Aug 29, 2022
Contributor
Author
|
thanks ! |
3 tasks
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithErrorCheck specifies a function fn which determines whether the passed
error should be marked as an error. The fn is called whenever a database/sql operation
finishes with an error.
close #1314
Almost base code is taken from #806.
I think it is good to check err as not nil before call
errCheck. User maybe don't expect to pass nil error toWithErrorCheck. How do you think ?