Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DataDog/dd-trace-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.7.2
Choose a base ref
...
head repository: DataDog/dd-trace-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.7.3
Choose a head ref
  • 5 commits
  • 14 files changed
  • 2 contributors

Commits on Apr 17, 2026

  1. feat(contrib/redis/rueidis): add SetOnInvalidations to `dedicatedCl… 

    …ient` (#4659)

Mirrors #4657 on `contrib/redis/rueidis`.

Fix `smoke-tests`.

- [x] Changed code has unit tests for its functionality at or near 100%
coverage.
- [x] New code is free of linting errors. You can check this by running
`make lint` locally.
- [x] New code doesn't break existing tests. You can check this by
running `make test` locally.
- [x] Add an appropriate team label so this PR gets put in the right
place for the release notes.
- [x] All generated files are up to date. You can check this by running
`make generate` locally.
- [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed
by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to
date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!
    @darccio
    darccio committed Apr 17, 2026
    Configuration menu
    Copy the full SHA
    a859be1 View commit details
    Browse the repository at this point in the history

  2. feat(contrib/valkey-io): bump valkey-go and add SetOnInvalidations wr… 

    …apper (#4657)

Upgrade valkey-go to v1.0.74, which extends DedicatedClient with
SetOnInvalidations for client-side caching invalidations. Delegate the
new hook on the traced dedicated client so the wrapper still implements
the upstream interface.

We cannot bump the valkey lib in our project.
They added the `SetOnInvalidations` on the `DedicatedClient` interface
-
valkey-io/valkey-go@26dc6e8

It create issue on DataDog lib side because it does not match the
interface
```console
~/work/DataDog/dd-trace-go/contrib/valkey-io/valkey-go git:(main) ✗ $ go test ./...
go: downloading github.com/DataDog/datadog-go v3.2.0+incompatible
go: downloading google.golang.org/genproto v0.0.0-20251022142026-3a174f9686a8
./valkey.go:129:13: cannot use &dedicatedClient{…} (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in argument to fn: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations)
./valkey.go:138:9: cannot use &dedicatedClient{…} (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in return statement: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations)
./valkey.go:165:29: cannot use (*dedicatedClient)(nil) (value of type *dedicatedClient) as "github.com/valkey-io/valkey-go".DedicatedClient value in variable declaration: *dedicatedClient does not implement "github.com/valkey-io/valkey-go".DedicatedClient (missing method SetOnInvalidations)
FAIL    github.com/DataDog/dd-trace-go/contrib/valkey-io/valkey-go/v2 [build failed]
FAIL
```

- [ ] Changed code has unit tests for its functionality at or near 100%
coverage.
- [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering
this feature have been added and enabled with the va.b.c-dev version
tag.
- [ ] There is a benchmark for any new code, or changes to existing
code.
- [x] If this interacts with the agent in a new way, a system test has
been added.
- [x] New code is free of linting errors. You can check this by running
`make lint` locally.
- [x] New code doesn't break existing tests. You can check this by
running `make test` locally.
- [ ] Add an appropriate team label so this PR gets put in the right
place for the release notes.
- [x] All generated files are up to date. You can check this by running
`make generate` locally.
- [x] Non-trivial go.mod changes, e.g. adding new modules, are reviewed
by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to
date by running `make fix-modules` locally.
    @Scorfly @darccio
    Scorfly authored and darccio committed Apr 17, 2026
    Configuration menu
    Copy the full SHA
    388ccd3 View commit details
    Browse the repository at this point in the history

  3. internal/version: v2.7.3

    @darccio
    darccio committed Apr 17, 2026
    Configuration menu
    Copy the full SHA
    1910a1b View commit details
    Browse the repository at this point in the history

  4. chore: make fix-modules && make generate

    @darccio
    darccio committed Apr 17, 2026
    Configuration menu
    Copy the full SHA
    8a5108f View commit details
    Browse the repository at this point in the history

  5. chore(internal/orchestrion): make fix-modules && make generate

    @darccio
    darccio committed Apr 17, 2026
    Configuration menu
    Copy the full SHA
    dc57de6 View commit details
    Browse the repository at this point in the history
Loading