Skip to content

Commit 91482d5

Browse files
faydeffaydef
authored
ci(macrobenchmarks): integrate apm-sdks-benchmarks configurations (#4663)
<!-- * New contributors are highly encouraged to read our [CONTRIBUTING](/CONTRIBUTING.md) documentation. * Commit and PR titles should be prefixed with the general area of the pull request's change. --> ### What does this PR do? Adds new parallel macrobenchmarks from `DataDog/apm-sdks-benchmarks` via GitLab `include: project:`, running both old and new configurations alongside each other during a transition period. <!-- * A brief description of the change being made with this pull request. * If the description here cannot be expressed in a succinct form, consider opening multiple pull requests instead of a single one. --> ### Motivation `apm-sdks-benchmarks` will be the single source of truth for all macrobenchmark configurations—future changes should happen there. <!-- * What inspired you to submit this pull request? * Link any related GitHub issues or PRs here. * If this resolves a GitHub issue, include "Fixes #XXXX" to link the issue and auto-close it on merge. --> ### Reviewer's Checklist <!-- * Authors can use this list as a reference to ensure that there are no problems during the review but the signing off is to be done by the reviewer(s). --> - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [ ] If this interacts with the agent in a new way, a system test has been added. - [ ] New code is free of linting errors. You can check this by running `make lint` locally. - [ ] New code doesn't break existing tests. You can check this by running `make test` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [ ] All generated files are up to date. You can check this by running `make generate` locally. - [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Unsure? Have a question? Request a review! Co-authored-by: fayssal.defaa <[email protected]>
1 parent a00ff76 commit 91482d5

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎.gitlab-ci.yml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ stages:
33
- generate
44
- benchmarks
55
- macrobenchmarks
6+
# These benchmarks are planned to replace the legacy macrobenchmarks long term
7+
- go-go-prof-app-parallel
8+
- go-go-prof-app-parallel-slo
69
- gates
710
- config-validation
811
- test-apps
@@ -145,3 +148,6 @@ include:
145148
- local: ".gitlab/test-apps.yml"
146149
- local: ".gitlab/docker-images-reliability-env.yml"
147150
- local: ".gitlab/configuration-central-validation.yml"
151+
- project: 'DataDog/apm-reliability/apm-sdks-benchmarks'
152+
file: '.gitlab/ci-go-go-prof-app-parallel.yml'
153+
ref: 'main'

0 commit comments

Comments
 (0)