Skip to content

Commit 7f4e243

Browse files
authored
Merge branch 'main' into eliottness/azure-apim-callout
2 parents 4229afe + 56e391d commit 7f4e243

2 files changed

Lines changed: 11 additions & 15 deletions

File tree

.github/workflows/main-branch-tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ jobs:
5151
go-version: [ "1.25", "1.26" ]
5252
fail-fast: false
5353
uses: ./.github/workflows/multios-unit-tests.yml
54+
permissions:
55+
contents: read
56+
id-token: write
57+
pull-requests: write
5458
with:
5559
go-version: ${{ matrix.go-version }}
5660
runs-on: ${{ matrix.runs-on }}

.github/workflows/system-tests.yml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,7 @@ jobs:
3838
runs-on: ubuntu-latest
3939
outputs:
4040
sha: ${{ steps.pin.outputs.sha }}
41-
dd-api-key: ${{ steps.dd-sts.outputs.api_key }}
4241
steps:
43-
- name: Get Datadog credentials
44-
id: dd-sts
45-
uses: DataDog/dd-sts-action@2e8187910199bd93129520183c093e19aa585c75
46-
with:
47-
policy: dd-trace-go
4842
- name: Checkout system-tests
4943
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
5044
with:
@@ -60,9 +54,6 @@ jobs:
6054
with:
6155
path: .git
6256
key: gitdb-system-tests-${{ steps.pin.outputs.sha }}
63-
- name: Get Credentials
64-
run: |
65-
echo "DD_API_KEY=${{ steps.dd-sts.outputs.api_key }}" >> "$GITHUB_ENV"
6657
system-tests:
6758
if: github.event_name != 'pull_request' || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'DataDog/dd-trace-go')
6859
# Note: Not using large runners because the jobs spawned by this pipeline
@@ -122,13 +113,13 @@ jobs:
122113
# APM scenarios requiring specific environment settings
123114
- scenario: APM_TRACING_E2E_SINGLE_SPAN
124115
env:
125-
DD_API_KEY=$SYSTEM_TESTS_E2E_DD_API_KEY
126-
DD_APPLICATION_KEY=$SYSTEM_TESTS_E2E_DD_APP_KEY
116+
DD_API_KEY=$DD_API_KEY
117+
DD_APPLICATION_KEY=$DD_APP_KEY
127118
DD_SITE="datadoghq.com"
128119
- scenario: APM_TRACING_E2E_OTEL
129120
env:
130-
DD_API_KEY=$SYSTEM_TESTS_E2E_DD_API_KEY
131-
DD_APPLICATION_KEY=$SYSTEM_TESTS_E2E_DD_APP_KEY
121+
DD_API_KEY=$DD_API_KEY
122+
DD_APPLICATION_KEY=$DD_APP_KEY
132123
DD_SITE="datadoghq.com"
133124
# GraphQL System Tests
134125
- scenario: GRAPHQL_APPSEC
@@ -176,16 +167,17 @@ jobs:
176167
ref: ${{ inputs.branch_ref || github.ref }}
177168
path: 'binaries/dd-trace-go'
178169

170+
# Use the app key policy to obtain DD_APP_KEY
179171
- name: Get Datadog credentials
180172
id: dd-sts
181173
uses: DataDog/dd-sts-action@2e8187910199bd93129520183c093e19aa585c75
182174
with:
183-
policy: dd-trace-go
175+
policy: dd-trace-go-app-key
184176

185177
- name: Set credentials
186178
run: |
187179
echo "DD_API_KEY=${{ steps.dd-sts.outputs.api_key }}" >> "$GITHUB_ENV"
188-
echo "SYSTEM_TESTS_E2E_DD_API_KEY=${{ steps.dd-sts.outputs.api_key }}" >> "$GITHUB_ENV"
180+
echo "DD_APP_KEY=${{ steps.dd-sts.outputs.app_key }}" >> "$GITHUB_ENV"
189181
190182
- name: Build weblog
191183
run: ./build.sh -i weblog

0 commit comments

Comments
 (0)