Skip to content

Commit 749408d

Browse files
hannahkmhannahkm
authored
fix: smoke tests fail on proxy issues (#4693)
<!-- * New contributors are highly encouraged to read our [CONTRIBUTING](/CONTRIBUTING.md) documentation. * Commit and PR titles should be prefixed with the general area of the pull request's change. --> ### What does this PR do? Allows smoke tests to fall back to `GOPROXY=direct` on proxy failures. <!-- * A brief description of the change being made with this pull request. * If the description here cannot be expressed in a succinct form, consider opening multiple pull requests instead of a single one. --> ### Motivation On agent releases, the proxy lags behind GitHub tagging, which can cause smoke tests to fail since proxy failures return error code 500. `GOPROXY` only falls through on 400 or 401, so `direct` used to get skipped. <!-- * What inspired you to submit this pull request? * Link any related GitHub issues or PRs here. * If this resolves a GitHub issue, include "Fixes #XXXX" to link the issue and auto-close it on merge. --> ### Reviewer's Checklist <!-- * Authors can use this list as a reference to ensure that there are no problems during the review but the signing off is to be done by the reviewer(s). --> - [ ] Changed code has unit tests for its functionality at or near 100% coverage. - [ ] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. - [ ] There is a benchmark for any new code, or changes to existing code. - [ ] If this interacts with the agent in a new way, a system test has been added. - [ ] New code is free of linting errors. You can check this by running `make lint` locally. - [ ] New code doesn't break existing tests. You can check this by running `make test` locally. - [ ] Add an appropriate team label so this PR gets put in the right place for the release notes. - [ ] All generated files are up to date. You can check this by running `make generate` locally. - [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally. Unsure? Have a question? Request a review! Co-authored-by: hannahs.kim <[email protected]>
1 parent 62de3fa commit 749408d

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

‎.github/workflows/smoke-tests.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ on:
2727

2828
env:
2929
TEST_RESULTS: /tmp/test-results # path to where test results will be saved
30+
GOPROXY: "proxy.golang.org|direct" # fall back to `direct` in case of proxy issues
3031

3132
permissions:
3233
id-token: write

0 commit comments

Comments
 (0)