fix(internal/telemetry): don't use default dependency loader in telemetry tests

darccio · darccio · commit 44d84197cebd · 2026-04-17T18:15:05.000+02:00
Root cause: commit a45c8032 in golang/go: "cmd/go: include test deps in buildinfo" (merged ~March 17, 2026, landed in gotip). Fixed golang/go#76926. Before this, test binary BuildInfo.Deps was empty → dependencies.Payload() returned nil → only Logs in flush → test passed. After: test deps populate Deps → AppDependenciesLoaded joins flush → 2 payloads → MessageBatch → test fails. Apparently this is flaky but went unnoticed. Looking at historical data, odds to fail since the commit landed on gotip were 1 of every 10-ish.
diff --git a/internal/telemetry/client_test.go b/internal/telemetry/client_test.go
@@ -1421,11 +1421,15 @@ func TestSendingFailures(t *testing.T) {
 		},
 	}
 
+	config := defaultConfig(cfg)
+	config.DependencyLoader = nil // prevent AppDependenciesLoaded from joining the flush and creating a MessageBatch
+	config.internalMetricsEnabled = false
+
 	c, err := newClient(internal.TracerConfig{
 		Service: "test-service",
 		Env:     "test-env",
 		Version: "1.0.0",
-	}, defaultConfig(cfg))
+	}, config)
 
 	require.NoError(t, err)
 	defer c.Close()
