ci: migrate CI secrets from AWS SSM to Vault KV#24
Merged
Conversation
Move secret retrieval in get_secrets.sh from aws ssm get-parameter to vault kv get, aligning with the pattern used by datadog-lambda-js.
duncanista
force-pushed
the
jordan.gonzalez/gitlab/secrets-from-kv
branch
from
March 31, 2026 20:13
9371215 to
7361429
Compare
rithikanarayan
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_secrets.shfromaws ssm get-parametertovault kv get, aligning with the pattern used bydatadog-lambda-jsTest plan
kv/k8s/gitlab-runner/dd-trace-dotnet-aws-lambda-layer/secretsDD_API_KEYand external ID are correctly resolved