don't delete the native loader library#17
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dockerfile.r2r script to preserve essential native libraries required for the Datadog tracer to function properly. The change ensures compatibility with dd-trace-dotnet v3.26.0 and later versions, which require the native loader library.
- Removes deletion of all
.sofiles to preserve the native loader library - Keeps
Datadog.Linux.ApiWrapper.x64.sodue to uncertainty about its necessity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
duncanista
approved these changes
Sep 9, 2025
duncanista
reviewed
Sep 10, 2025
|
|
||
| # remove files not used in AWS Lambda to keep the layer as small as possible | ||
| RUN \ | ||
| # Profiling and Crash Tracking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keep (don't delete) the native loader library
Datadog.Trace.ClrProfiler.Native.so(1.5 MB) and it'sloader.conffile.Motivation
Using the tracer without the native loader was never officially supported, and now it's required since
dd-trace-dotnetv3.26.0 (see DataDog/dd-trace-dotnet#7462).Testing Guidelines
Tracer should load and instrument as normal. Without these changes, it should fail to load.
Additional Notes
New layout, where
linux-<arch>is eitherlinux-x64orlinux-arm64:└── datadog ├── linux-<arch> + │ ├── Datadog.Trace.ClrProfiler.Native.so │ ├── Datadog.Tracer.Native.so + │ └── loader.conf ├── net6.0 │ └── Datadog.Trace.dll └── tracer_version.txtTypes of Changes
Check all that apply