Skip to content

Attempt to fix more flake in System.Data.SqlClient#8899

Merged
bouwkast merged 1 commit into
masterfrom
steven/more-ado-flake
Jul 14, 2026
Merged

Attempt to fix more flake in System.Data.SqlClient#8899
bouwkast merged 1 commit into
masterfrom
steven/more-ado-flake

Conversation

@bouwkast

@bouwkast bouwkast commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Flushes the large RunAllAsync trace before starting the SqlCommandVb trace

Reason for change

SystemDataSqlClientTests.SubmitsTraces intermittently received 105 spans, consistent with the entire initial RunAllAsync trace being absent.

The previous mitigation flushed only after both traces had completed, leaving a timing window for the first trace.

Implementation details

Moved the flush

Test coverage

This is it

Other details

Follow-up to #8871

#incident-57303

@github-actions github-actions Bot added the area:tests unit tests, integration tests label Jul 13, 2026
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8899) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration70.45 ± (70.52 - 70.87) ms71.07 ± (71.40 - 71.97) ms+0.9%✅⬆️
.NET Framework 4.8 - Bailout
duration74.53 ± (74.42 - 74.73) ms76.47 ± (76.35 - 76.88) ms+2.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1096.26 ± (1097.79 - 1107.78) ms1082.22 ± (1082.08 - 1088.31) ms-1.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.08 ± (22.04 - 22.11) ms22.30 ± (22.26 - 22.34) ms+1.0%✅⬆️
process.time_to_main_ms80.85 ± (80.71 - 81.00) ms83.00 ± (82.77 - 83.23) ms+2.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.98 ± (10.98 - 10.98) MB10.99 ± (10.99 - 10.99) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.09 ± (22.06 - 22.12) ms22.04 ± (22.01 - 22.08) ms-0.2%✅
process.time_to_main_ms82.13 ± (82.01 - 82.25) ms82.63 ± (82.43 - 82.83) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed11.03 ± (11.02 - 11.03) MB11.02 ± (11.01 - 11.02) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms209.58 ± (208.59 - 210.57) ms208.57 ± (207.77 - 209.36) ms-0.5%✅
process.time_to_main_ms537.58 ± (536.19 - 538.97) ms533.62 ± (532.65 - 534.59) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.52 ± (49.50 - 49.55) MB49.43 ± (49.40 - 49.46) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.8%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.82 ± (20.79 - 20.85) ms21.01 ± (20.96 - 21.05) ms+0.9%✅⬆️
process.time_to_main_ms70.22 ± (70.10 - 70.35) ms71.86 ± (71.64 - 72.09) ms+2.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.70 ± (10.70 - 10.70) MB10.72 ± (10.71 - 10.72) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.01 ± (20.96 - 21.05) ms20.89 ± (20.84 - 20.93) ms-0.6%✅
process.time_to_main_ms73.84 ± (73.59 - 74.09) ms73.12 ± (72.92 - 73.32) ms-1.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.82 ± (10.82 - 10.82) MB10.83 ± (10.83 - 10.83) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms371.24 ± (369.25 - 373.22) ms376.61 ± (373.88 - 379.33) ms+1.4%✅⬆️
process.time_to_main_ms540.38 ± (539.33 - 541.43) ms539.78 ± (538.55 - 541.01) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.61 ± (50.59 - 50.63) MB50.60 ± (50.58 - 50.62) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.19 ± (19.16 - 19.22) ms18.96 ± (18.94 - 18.99) ms-1.2%✅
process.time_to_main_ms70.10 ± (69.91 - 70.29) ms69.09 ± (68.96 - 69.21) ms-1.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.74 - 7.75) MB7.76 ± (7.76 - 7.77) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.01 ± (18.98 - 19.04) ms18.98 ± (18.94 - 19.01) ms-0.2%✅
process.time_to_main_ms70.79 ± (70.64 - 70.93) ms70.70 ± (70.59 - 70.81) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.81 ± (7.80 - 7.82) MB7.80 ± (7.80 - 7.81) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms295.61 ± (293.48 - 297.74) ms298.93 ± (296.84 - 301.02) ms+1.1%✅⬆️
process.time_to_main_ms492.41 ± (491.38 - 493.45) ms491.96 ± (490.99 - 492.93) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.96 ± (37.93 - 37.99) MB37.96 ± (37.93 - 37.98) MB-0.0%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.3%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration191.57 ± (191.68 - 192.37) ms189.38 ± (189.30 - 189.95) ms-1.1%✅
.NET Framework 4.8 - Bailout
duration195.09 ± (194.95 - 195.33) ms192.89 ± (192.80 - 193.18) ms-1.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1183.12 ± (1186.81 - 1197.18) ms1162.53 ± (1165.71 - 1173.32) ms-1.7%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms185.10 ± (184.56 - 185.65) ms184.01 ± (183.72 - 184.30) ms-0.6%✅
process.time_to_main_ms80.26 ± (80.01 - 80.50) ms79.42 ± (79.24 - 79.60) ms-1.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.20 ± (16.17 - 16.22) MB16.34 ± (16.31 - 16.37) MB+0.9%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.7%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms185.86 ± (185.26 - 186.46) ms183.55 ± (183.33 - 183.77) ms-1.2%✅
process.time_to_main_ms82.16 ± (81.88 - 82.44) ms80.96 ± (80.85 - 81.07) ms-1.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.23 ± (16.21 - 16.26) MB16.08 ± (15.94 - 16.22) MB-0.9%✅
runtime.dotnet.threads.count21 ± (21 - 21)20 ± (20 - 20)-2.5%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms377.54 ± (376.28 - 378.80) ms371.89 ± (370.95 - 372.83) ms-1.5%✅
process.time_to_main_ms529.19 ± (528.00 - 530.38) ms524.10 ± (523.02 - 525.18) ms-1.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.01 ± (57.96 - 58.06) MB57.93 ± (57.87 - 57.99) MB-0.1%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms190.08 ± (189.53 - 190.62) ms187.58 ± (187.29 - 187.87) ms-1.3%✅
process.time_to_main_ms70.62 ± (70.36 - 70.87) ms69.60 ± (69.47 - 69.74) ms-1.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.35 ± (16.27 - 16.43) MB15.60 ± (15.41 - 15.78) MB-4.6%✅
runtime.dotnet.threads.count18 ± (18 - 19)17 ± (17 - 18)-6.1%✅
.NET 6 - Bailout
process.internal_duration_ms188.61 ± (188.35 - 188.86) ms186.56 ± (186.38 - 186.74) ms-1.1%✅
process.time_to_main_ms71.14 ± (71.04 - 71.24) ms70.70 ± (70.65 - 70.75) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.92 ± (15.75 - 16.09) MB15.72 ± (15.54 - 15.89) MB-1.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (18 - 19)-2.3%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms582.36 ± (579.60 - 585.12) ms578.74 ± (575.80 - 581.68) ms-0.6%✅
process.time_to_main_ms536.40 ± (534.68 - 538.13) ms530.11 ± (529.37 - 530.86) ms-1.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.55 ± (61.49 - 61.62) MB61.53 ± (61.49 - 61.58) MB-0.0%✅
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)+0.6%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms187.59 ± (186.95 - 188.24) ms185.49 ± (185.34 - 185.65) ms-1.1%✅
process.time_to_main_ms69.76 ± (69.48 - 70.05) ms68.80 ± (68.68 - 68.93) ms-1.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.87 ± (11.83 - 11.91) MB11.99 ± (11.96 - 12.02) MB+1.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+1.4%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms185.46 ± (185.28 - 185.64) ms184.69 ± (184.51 - 184.86) ms-0.4%✅
process.time_to_main_ms70.47 ± (70.41 - 70.54) ms69.98 ± (69.92 - 70.05) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.96 ± (11.90 - 12.01) MB11.84 ± (11.73 - 11.94) MB-1.0%✅
runtime.dotnet.threads.count19 ± (18 - 19)18 ± (18 - 19)-0.9%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms508.26 ± (505.21 - 511.30) ms512.40 ± (509.59 - 515.20) ms+0.8%✅⬆️
process.time_to_main_ms490.16 ± (488.18 - 492.14) ms481.06 ± (480.39 - 481.73) ms-1.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.42 ± (51.39 - 51.46) MB51.43 ± (51.40 - 51.46) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.4%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (72ms)  : 67, 76
    master - mean (71ms)  : 68, 73

    section Bailout
    This PR (8899) - mean (77ms)  : 72, 81
    master - mean (75ms)  : 73, 76

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (1,085ms)  : 1040, 1130
    master - mean (1,103ms)  : 1027, 1179
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (112ms)  : 107, 116
    master - mean (109ms)  : 106, 113

    section Bailout
    This PR (8899) - mean (111ms)  : 106, 115
    master - mean (111ms)  : 109, 112

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (778ms)  : 756, 800
    master - mean (786ms)  : 764, 807
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (99ms)  : 93, 104
    master - mean (97ms)  : 95, 99

    section Bailout
    This PR (8899) - mean (100ms)  : 95, 105
    master - mean (102ms)  : 96, 108

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (944ms)  : 902, 987
    master - mean (942ms)  : 906, 978
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (95ms)  : 91, 98
    master - mean (96ms)  : 92, 100

    section Bailout
    This PR (8899) - mean (96ms)  : 95, 98
    master - mean (96ms)  : 95, 98

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (821ms)  : 782, 859
    master - mean (819ms)  : 776, 863
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (190ms)  : 186, 193
    master - mean (192ms)  : 188, 196

    section Bailout
    This PR (8899) - mean (193ms)  : 191, 195
    master - mean (195ms)  : 193, 197

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (1,170ms)  : 1114, 1225
    master - mean (1,192ms)  : 1115, 1269
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (271ms)  : 267, 276
    master - mean (273ms)  : 262, 285

    section Bailout
    This PR (8899) - mean (272ms)  : 269, 275
    master - mean (276ms)  : 263, 289

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (934ms)  : 916, 951
    master - mean (946ms)  : 908, 983
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (265ms)  : 262, 269
    master - mean (269ms)  : 256, 282

    section Bailout
    This PR (8899) - mean (265ms)  : 263, 267
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (1,138ms)  : 1099, 1177
    master - mean (1,154ms)  : 1089, 1219
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8899) - mean (264ms)  : 261, 266
    master - mean (267ms)  : 254, 280

    section Bailout
    This PR (8899) - mean (264ms)  : 262, 266
    master - mean (265ms)  : 263, 268

    section CallTarget+Inlining+NGEN
    This PR (8899) - mean (1,024ms)  : 979, 1070
    master - mean (1,037ms)  : 980, 1094
Loading

@pr-commenter

pr-commenter Bot commented Jul 13, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-13 15:09:44

Comparing candidate commit 0509df0 in PR branch steven/more-ado-flake with baseline commit 8f5b860 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 1 unstable metrics, 57 known flaky benchmarks, 69 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5583.298op/s; -5214.440op/s] or [-6.374%; -5.953%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog netcoreapp3.1

  • unstable execution_time [-18.699ms; +3.078ms] or [-9.516%; +1.567%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-7857.117op/s; -7375.249op/s] or [-9.316%; -8.745%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-34.655ms; -10.517ms] or [-17.430%; -5.290%]
  • 🟥 throughput [-9331.398op/s; -7112.103op/s] or [-9.488%; -7.231%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+323.471ms; +325.768ms] or [+160.518%; +161.658%]
  • 🟥 throughput [-40.786op/s; -36.826op/s] or [-7.338%; -6.626%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+379.131ms; +382.312ms] or [+299.537%; +302.050%]
  • 🟩 throughput [+90.561op/s; +95.886op/s] or [+11.940%; +12.642%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+394.326ms; +395.503ms] or [+348.964%; +350.005%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-15.551ms; -11.385ms] or [-7.263%; -5.317%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-264613.643op/s; -260401.230op/s] or [-27.018%; -26.588%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.648ms; -21.716ms] or [-11.884%; -9.684%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-169728.673op/s; -153666.098op/s] or [-24.387%; -22.079%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+10097.536op/s; +12737.489op/s] or [+8.044%; +10.147%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+406973.844op/s; +455935.798op/s] or [+13.570%; +15.203%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.746ms; -14.414ms] or [-8.641%; -6.644%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.953ms; +300.590ms] or [+149.876%; +150.195%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.235ms; +302.435ms] or [+150.905%; +152.519%]
  • 🟩 throughput [+687.249op/s; +898.983op/s] or [+5.256%; +6.876%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.557ms; +303.452ms] or [+151.397%; +152.856%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.406ms; +298.279ms] or [+145.583%; +146.503%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+292.564ms; +296.299ms] or [+143.024%; +144.850%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+300.896ms; +302.877ms] or [+150.387%; +151.378%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+22.049µs; +45.724µs] or [+7.039%; +14.597%]
  • 🟥 throughput [-426.105op/s; -226.906op/s] or [-13.283%; -7.073%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.339ms; +300.085ms] or [+149.401%; +149.773%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+405.984ms; +414.245ms] or [+441.119%; +450.094%]
  • 🟩 throughput [+884.513op/s; +1044.234op/s] or [+7.268%; +8.581%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+372.324ms; +378.378ms] or [+282.702%; +287.299%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+299.431ms; +364.928ms] or [+137.675%; +167.790%]
  • 🟥 throughput [-546.730op/s; -494.752op/s] or [-49.539%; -44.829%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+150.819ms; +297.474ms] or [+64.273%; +126.771%]
  • 🟥 throughput [-675.952op/s; -592.402op/s] or [-45.086%; -39.513%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+326.550ms; +334.084ms] or [+195.315%; +199.821%]
  • 🟥 throughput [-398.578op/s; -363.184op/s] or [-27.752%; -25.288%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+301.637ms; +303.294ms] or [+151.899%; +152.733%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+300.610ms; +303.484ms] or [+150.636%; +152.076%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+300.281ms; +303.375ms] or [+150.848%; +152.403%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+300.491ms; +302.404ms] or [+150.897%; +151.857%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+296.753ms; +299.062ms] or [+146.731%; +147.873%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.379ms; +306.303ms] or [+153.259%; +155.248%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+301.399ms; +303.291ms] or [+151.275%; +152.224%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+300.275ms; +302.928ms] or [+149.660%; +150.982%]
  • 🟩 throughput [+54252.638op/s; +57831.113op/s] or [+10.773%; +11.483%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+301.822ms; +304.793ms] or [+150.154%; +151.632%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.428ms; -12.769ms] or [-7.639%; -5.938%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+6.550µs; +49.821µs] or [+1.618%; +12.306%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.719KB; -19.697KB] or [-7.193%; -7.185%]
  • unstable execution_time [-47.937µs; +6.700µs] or [-9.474%; +1.324%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-17.099KB; -17.081KB] or [-6.233%; -6.227%]
  • unstable execution_time [-66.327µs; -5.466µs] or [-11.494%; -0.947%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+11.160µs; +17.298µs] or [+26.379%; +40.888%]
  • 🟥 throughput [-6737.520op/s; -4685.036op/s] or [-28.363%; -19.723%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.885µs; -6.057µs] or [-21.542%; -9.397%]
  • unstable throughput [+1490.530op/s; +3207.033op/s] or [+9.145%; +19.676%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.546ms; +303.929ms] or [+152.924%; +153.623%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.770ms; +306.528ms] or [+154.618%; +156.022%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.551ms; +303.284ms] or [+149.962%; +151.831%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+298.961ms; +300.829ms] or [+149.005%; +149.936%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+298.640ms; +300.984ms] or [+149.963%; +151.140%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.949ms; +305.292ms] or [+153.636%; +154.824%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.776ms; +300.607ms] or [+149.530%; +149.944%]
  • 🟩 throughput [+61097662.285op/s; +61443960.278op/s] or [+44.495%; +44.747%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+341.509ms; +400.119ms] or [+424.728%; +497.619%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.564ms; +299.765ms] or [+148.917%; +149.516%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+68016.291op/s; +79320.790op/s] or [+6.350%; +7.406%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+50259.960op/s; +70057.559op/s] or [+5.817%; +8.109%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+81640.562op/s; +91729.939op/s] or [+8.108%; +9.110%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+43757.022op/s; +50083.916op/s] or [+7.945%; +9.094%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+24619.985op/s; +34480.029op/s] or [+5.511%; +7.718%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+73047.018op/s; +92373.350op/s] or [+8.161%; +10.320%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@bouwkast
bouwkast marked this pull request as ready for review July 13, 2026 19:15
@bouwkast
bouwkast requested review from a team as code owners July 13, 2026 19:15
@bouwkast
bouwkast requested review from vandonr and removed request for a team July 13, 2026 19:15
@bouwkast
bouwkast merged commit d51c2a5 into master Jul 14, 2026
140 checks passed
@bouwkast
bouwkast deleted the steven/more-ado-flake branch July 14, 2026 14:03
@github-actions github-actions Bot added this to the vNext-v3 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@vandonr vandonr Awaiting requested review from vandonr vandonr is a code owner automatically assigned from DataDog/apm-idm-dotnet

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwkast @zacharycmontoya