[Tests] Handle UTF-16 output from ProcDump v12.01#8890
Merged
Conversation
IIS x64 tests are hanging only change I see is that procdump appears to have updated so trying to disable this
github-actions
Bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8890) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (72ms) : 67, 77
master - mean (73ms) : 69, 77
section Bailout
This PR (8890) - mean (74ms) : 72, 76
master - mean (76ms) : 73, 80
section CallTarget+Inlining+NGEN
This PR (8890) - mean (1,078ms) : 1036, 1121
master - mean (1,081ms) : 1041, 1122
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (111ms) : 106, 116
master - mean (113ms) : 107, 119
section Bailout
This PR (8890) - mean (110ms) : 108, 112
master - mean (110ms) : 107, 114
section CallTarget+Inlining+NGEN
This PR (8890) - mean (779ms) : 750, 808
master - mean (776ms) : 753, 799
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (96ms) : 93, 100
master - mean (96ms) : 93, 99
section Bailout
This PR (8890) - mean (97ms) : 95, 99
master - mean (97ms) : 96, 98
section CallTarget+Inlining+NGEN
This PR (8890) - mean (941ms) : 906, 977
master - mean (936ms) : 892, 981
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (98ms) : 94, 103
master - mean (97ms) : 92, 103
section Bailout
This PR (8890) - mean (98ms) : 93, 102
master - mean (97ms) : 93, 102
section CallTarget+Inlining+NGEN
This PR (8890) - mean (812ms) : 777, 847
master - mean (816ms) : 769, 863
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (202ms) : 196, 208
master - mean (202ms) : 196, 207
section Bailout
This PR (8890) - mean (207ms) : 203, 211
master - mean (204ms) : 199, 209
section CallTarget+Inlining+NGEN
This PR (8890) - mean (1,216ms) : 1171, 1261
master - mean (1,214ms) : 1169, 1260
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (291ms) : 285, 297
master - mean (291ms) : 284, 299
section Bailout
This PR (8890) - mean (291ms) : 285, 297
master - mean (289ms) : 283, 296
section CallTarget+Inlining+NGEN
This PR (8890) - mean (971ms) : 945, 997
master - mean (975ms) : 952, 997
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (282ms) : 275, 289
master - mean (284ms) : 279, 290
section Bailout
This PR (8890) - mean (283ms) : 276, 291
master - mean (284ms) : 276, 291
section CallTarget+Inlining+NGEN
This PR (8890) - mean (1,172ms) : 1138, 1206
master - mean (1,169ms) : 1132, 1207
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8890) - mean (281ms) : 274, 288
master - mean (278ms) : 273, 284
section Bailout
This PR (8890) - mean (283ms) : 277, 289
master - mean (281ms) : 276, 287
section CallTarget+Inlining+NGEN
This PR (8890) - mean (1,046ms) : 1009, 1084
master - mean (1,050ms) : 1008, 1091
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This reverts commit 72bbb1e. It still downloaded proc dump
bouwkast
changed the title
BenchmarksBenchmark execution time: 2026-07-10 17:01:34 Comparing candidate commit 836557d in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.
|
bouwkast
marked this pull request as ready for review
July 10, 2026 17:02
link04
approved these changes
Jul 10, 2026
bouwkast
enabled auto-merge (squash)
July 10, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Normalize ProcDump output before evaluating its startup and shutdown messages.
Reason for change
Windows x64 integration tests started hanging after the unversioned Microsoft download began serving ProcDump v12.01.
The test harness:
ProcDump v12.01 emits redirected output as UTF-16. The test helper read this with embedded null characters, such as
P\0r\0e\0s\0s.... Consequently, the exact readiness-message comparison failed and the instrumented process remained suspended indefinitely.The same encoding change prevented the helper from recognizing the normal
"Dump count not reached"shutdown message. It therefore treated normal shutdown as abnormal and logged ProcDump’s entire buffered exception history.This primarily affected x64 tests because ProcDump crash monitoring is disabled for x86 tests.
Implementation details
Output from older ProcDump versions is unchanged because removing null characters is a no-op.
Test coverage
Tested locally with:
Datadog.Trace.Security.IntegrationTests.AspNetCore5BlockingTemplatesJson.TestGetOther details
This only changes test infrastructure behavior. Crash-dump monitoring remains enabled, and this change does not pin a ProcDump version.
#incident-57303