Remove unused kafka services from docker-compose.ym#8855
Merged
Conversation
andrewlock
added
the
area:builds
andrewlock
enabled auto-merge (squash)
June 30, 2026 16:24
zacharycmontoya
approved these changes
Jun 30, 2026
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8855) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (72ms) : 68, 76
master - mean (72ms) : 68, 77
section Bailout
This PR (8855) - mean (74ms) : 71, 76
master - mean (76ms) : 72, 79
section CallTarget+Inlining+NGEN
This PR (8855) - mean (1,079ms) : 1028, 1129
master - mean (1,076ms) : 1035, 1118
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (113ms) : 106, 120
master - mean (113ms) : 106, 119
section Bailout
This PR (8855) - mean (110ms) : 108, 112
master - mean (111ms) : 107, 115
section CallTarget+Inlining+NGEN
This PR (8855) - mean (779ms) : 765, 793
master - mean (772ms) : 751, 793
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (101ms) : 96, 107
master - mean (96ms) : 93, 99
section Bailout
This PR (8855) - mean (99ms) : 95, 102
master - mean (97ms) : 95, 98
section CallTarget+Inlining+NGEN
This PR (8855) - mean (939ms) : 896, 982
master - mean (934ms) : 890, 979
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (95ms) : 93, 98
master - mean (98ms) : 92, 104
section Bailout
This PR (8855) - mean (97ms) : 94, 99
master - mean (99ms) : 94, 103
section CallTarget+Inlining+NGEN
This PR (8855) - mean (816ms) : 781, 852
master - mean (812ms) : 781, 843
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (208ms) : 204, 213
master - mean (207ms) : 203, 212
section Bailout
This PR (8855) - mean (211ms) : 208, 215
master - mean (211ms) : 208, 215
section CallTarget+Inlining+NGEN
This PR (8855) - mean (1,230ms) : 1189, 1271
master - mean (1,227ms) : 1178, 1275
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (295ms) : 287, 304
master - mean (297ms) : 290, 304
section Bailout
This PR (8855) - mean (297ms) : 292, 301
master - mean (298ms) : 292, 304
section CallTarget+Inlining+NGEN
This PR (8855) - mean (993ms) : 973, 1014
master - mean (993ms) : 968, 1019
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (288ms) : 281, 295
master - mean (291ms) : 285, 298
section Bailout
This PR (8855) - mean (286ms) : 279, 293
master - mean (290ms) : 284, 296
section CallTarget+Inlining+NGEN
This PR (8855) - mean (1,185ms) : 1152, 1218
master - mean (1,178ms) : 1131, 1226
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8855) - mean (289ms) : 281, 296
master - mean (287ms) : 282, 293
section Bailout
This PR (8855) - mean (287ms) : 281, 293
master - mean (288ms) : 282, 293
section CallTarget+Inlining+NGEN
This PR (8855) - mean (1,056ms) : 1008, 1104
master - mean (1,053ms) : 1004, 1102
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-06-30 17:13:57 Comparing candidate commit d5633ae in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 62 known flaky benchmarks, 64 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove unused kafka services from docker-compose.yml
Reason for change
These services are never started and are not required
Implementation details
Delete the lines from the docker-compose. I checked, and the
KAFKA_CONFLUENT_SCHEMA_REGISTRY_URLURL is optional (and the service was never started in practice anyway, so it was potentially harmful too😅)Test coverage
This is the test - if the tests pass we're good
Other details
Noticed while pinning docker images and updating VMs