[Profiler] Try fixing flakiness#8813
Merged
Merged
Conversation
github-actions
Bot
added
the
area:profiler
gleocadie
force-pushed
the
gleocadie/flaky-test-fixing
branch
from
June 22, 2026 12:19
ff391ca to
3257231
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8813) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (73ms) : 69, 76
master - mean (72ms) : 68, 76
section Bailout
This PR (8813) - mean (75ms) : 72, 79
master - mean (77ms) : 73, 80
section CallTarget+Inlining+NGEN
This PR (8813) - mean (1,077ms) : 1032, 1122
master - mean (1,078ms) : 1036, 1120
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (113ms) : 106, 120
master - mean (112ms) : 107, 118
section Bailout
This PR (8813) - mean (110ms) : 108, 113
master - mean (112ms) : 107, 117
section CallTarget+Inlining+NGEN
This PR (8813) - mean (777ms) : 759, 794
master - mean (774ms) : 752, 796
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (101ms) : 94, 107
master - mean (99ms) : 95, 104
section Bailout
This PR (8813) - mean (99ms) : 94, 103
master - mean (99ms) : 96, 102
section CallTarget+Inlining+NGEN
This PR (8813) - mean (936ms) : 893, 978
master - mean (935ms) : 897, 973
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (95ms) : 92, 97
master - mean (95ms) : 92, 98
section Bailout
This PR (8813) - mean (96ms) : 94, 98
master - mean (98ms) : 92, 104
section CallTarget+Inlining+NGEN
This PR (8813) - mean (815ms) : 784, 846
master - mean (812ms) : 779, 846
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (202ms) : 195, 208
master - mean (202ms) : 195, 209
section Bailout
This PR (8813) - mean (206ms) : 203, 209
master - mean (206ms) : 199, 213
section CallTarget+Inlining+NGEN
This PR (8813) - mean (1,204ms) : 1170, 1238
master - mean (1,203ms) : 1162, 1245
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (289ms) : 280, 297
master - mean (286ms) : 278, 294
section Bailout
This PR (8813) - mean (290ms) : 285, 295
master - mean (290ms) : 283, 298
section CallTarget+Inlining+NGEN
This PR (8813) - mean (972ms) : 953, 991
master - mean (966ms) : 947, 985
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (283ms) : 277, 289
master - mean (283ms) : 276, 290
section Bailout
This PR (8813) - mean (284ms) : 278, 291
master - mean (282ms) : 278, 287
section CallTarget+Inlining+NGEN
This PR (8813) - mean (1,165ms) : 1118, 1212
master - mean (1,169ms) : 1121, 1218
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8813) - mean (279ms) : 273, 285
master - mean (282ms) : 273, 290
section Bailout
This PR (8813) - mean (284ms) : 272, 295
master - mean (281ms) : 272, 289
section CallTarget+Inlining+NGEN
This PR (8813) - mean (1,093ms) : 741, 1445
master - mean (1,043ms) : 996, 1089
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-06-23 09:55:04 Comparing candidate commit 1752313 in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 69 metrics, 0 unstable metrics, 63 known flaky benchmarks, 63 flaky benchmarks without significant changes.
|
gleocadie
marked this pull request as ready for review
June 22, 2026 14:16
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b634b6cb91
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Change scenario to prevent this test from being flaky.
Reason for change
This test is flaky on 32-bits windows in CI.
A previous run showed that only 2 request were sent: 1 was cancel (
SetEndpointnot called) and the second one landed while the profiler was shutting down.We use an exception scenario because it helps in the determinism of the test.
Implementation details
Change to exception scenario instead.
Test coverage
Other details