Fix local MSBuild issue with CompileSamples#8807
Conversation
BenchmarksBenchmark execution time: 2026-06-19 10:15:02 Comparing candidate commit 8c7856b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8807) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (74ms) : 71, 77
master - mean (74ms) : 70, 77
section Bailout
This PR (8807) - mean (78ms) : 75, 81
master - mean (78ms) : 76, 80
section CallTarget+Inlining+NGEN
This PR (8807) - mean (1,095ms) : 1057, 1133
master - mean (1,092ms) : 1049, 1136
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (116ms) : 110, 121
master - mean (114ms) : 109, 118
section Bailout
This PR (8807) - mean (114ms) : 111, 117
master - mean (115ms) : 111, 118
section CallTarget+Inlining+NGEN
This PR (8807) - mean (795ms) : 772, 817
master - mean (794ms) : 766, 823
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (101ms) : 97, 106
master - mean (101ms) : 97, 104
section Bailout
This PR (8807) - mean (101ms) : 100, 103
master - mean (106ms) : 101, 110
section CallTarget+Inlining+NGEN
This PR (8807) - mean (958ms) : 922, 993
master - mean (957ms) : 916, 997
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (102ms) : 97, 106
master - mean (99ms) : 96, 102
section Bailout
This PR (8807) - mean (103ms) : 98, 107
master - mean (100ms) : 98, 101
section CallTarget+Inlining+NGEN
This PR (8807) - mean (825ms) : 782, 867
master - mean (821ms) : 784, 857
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (202ms) : 196, 208
master - mean (199ms) : 193, 206
section Bailout
This PR (8807) - mean (205ms) : 200, 211
master - mean (203ms) : 196, 210
section CallTarget+Inlining+NGEN
This PR (8807) - mean (1,209ms) : 1170, 1249
master - mean (1,199ms) : 1159, 1239
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (291ms) : 283, 299
master - mean (288ms) : 283, 294
section Bailout
This PR (8807) - mean (291ms) : 286, 296
master - mean (288ms) : 283, 293
section CallTarget+Inlining+NGEN
This PR (8807) - mean (973ms) : 949, 998
master - mean (966ms) : 948, 983
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (283ms) : 275, 291
master - mean (282ms) : 277, 287
section Bailout
This PR (8807) - mean (282ms) : 274, 290
master - mean (281ms) : 277, 285
section CallTarget+Inlining+NGEN
This PR (8807) - mean (1,170ms) : 1129, 1212
master - mean (1,160ms) : 1127, 1192
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8807) - mean (284ms) : 274, 294
master - mean (280ms) : 273, 286
section Bailout
This PR (8807) - mean (284ms) : 275, 294
master - mean (279ms) : 274, 284
section CallTarget+Inlining+NGEN
This PR (8807) - mean (1,051ms) : 1008, 1093
master - mean (1,043ms) : 995, 1090
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Fixes
CompileSamplesfailing locally when only Visual Studio 2026 is installedReason for change
The version of Nuke we're using doesn't "know" about the newer version of Visual Studio . MSBuild, so we have a wrapper function that "teaches" it about these (and about the "custom" location we use in the GitLab install). The downside is that we have to make sure to use it everywhere, and we were missing a couple of places.
Implementation details
Add missing
SetMSBuildPath()callsTest coverage
Tested locally, it fixes things that were broken before