[TESTS] Fix monitoring home calculation fallback for tests#8798
Conversation
andrewlock
left a comment
There was a problem hiding this comment.
LGTM, thanks for this, and sorry! 🙈
BenchmarksBenchmark execution time: 2026-06-18 09:42:29 Comparing candidate commit 2dd08e5 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8798) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (75ms) : 72, 78
master - mean (74ms) : 71, 77
section Bailout
This PR (8798) - mean (77ms) : 75, 80
master - mean (79ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8798) - mean (1,099ms) : 1044, 1153
master - mean (1,094ms) : 1052, 1136
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (116ms) : 112, 121
master - mean (116ms) : 111, 121
section Bailout
This PR (8798) - mean (115ms) : 111, 118
master - mean (116ms) : 112, 120
section CallTarget+Inlining+NGEN
This PR (8798) - mean (787ms) : 766, 809
master - mean (793ms) : 771, 815
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (102ms) : 98, 107
master - mean (101ms) : 97, 104
section Bailout
This PR (8798) - mean (102ms) : 98, 106
master - mean (102ms) : 99, 105
section CallTarget+Inlining+NGEN
This PR (8798) - mean (956ms) : 911, 1000
master - mean (953ms) : 915, 991
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (100ms) : 96, 105
master - mean (101ms) : 97, 105
section Bailout
This PR (8798) - mean (102ms) : 98, 106
master - mean (101ms) : 98, 103
section CallTarget+Inlining+NGEN
This PR (8798) - mean (818ms) : 787, 850
master - mean (823ms) : 788, 858
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (202ms) : 196, 207
master - mean (201ms) : 197, 205
section Bailout
This PR (8798) - mean (206ms) : 201, 211
master - mean (204ms) : 201, 207
section CallTarget+Inlining+NGEN
This PR (8798) - mean (1,205ms) : 1158, 1253
master - mean (1,201ms) : 1153, 1249
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (289ms) : 280, 297
master - mean (290ms) : 283, 297
section Bailout
This PR (8798) - mean (287ms) : 281, 294
master - mean (290ms) : 284, 296
section CallTarget+Inlining+NGEN
This PR (8798) - mean (966ms) : 945, 987
master - mean (968ms) : 947, 989
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (280ms) : 274, 286
master - mean (284ms) : 278, 290
section Bailout
This PR (8798) - mean (281ms) : 275, 288
master - mean (282ms) : 278, 287
section CallTarget+Inlining+NGEN
This PR (8798) - mean (1,169ms) : 1128, 1210
master - mean (1,168ms) : 1135, 1200
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8798) - mean (281ms) : 276, 286
master - mean (280ms) : 273, 287
section Bailout
This PR (8798) - mean (284ms) : 278, 290
master - mean (279ms) : 273, 285
section CallTarget+Inlining+NGEN
This PR (8798) - mean (1,048ms) : 1007, 1089
master - mean (1,038ms) : 1002, 1075
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Update calculation method for monitoring home folder when env var is not set
Reason for change
Tests were failing locally when monitoring home env var was missing
Implementation details
Pointed to
artifacts/monitoring-homeinstead of oldshared/bin/monitoring-homeTest coverage
Other details