Fix flake in profiling demo app#8793
Conversation
BenchmarksBenchmark execution time: 2026-06-16 09:18:17 Comparing candidate commit 6e23f75 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8793) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (75ms) : 72, 78
master - mean (74ms) : 71, 77
section Bailout
This PR (8793) - mean (79ms) : 76, 82
master - mean (78ms) : 74, 81
section CallTarget+Inlining+NGEN
This PR (8793) - mean (1,100ms) : 1059, 1142
master - mean (1,091ms) : 1044, 1137
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (116ms) : 111, 121
master - mean (116ms) : 110, 122
section Bailout
This PR (8793) - mean (116ms) : 113, 120
master - mean (114ms) : 111, 117
section CallTarget+Inlining+NGEN
This PR (8793) - mean (791ms) : 762, 820
master - mean (791ms) : 769, 813
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (102ms) : 99, 105
master - mean (102ms) : 98, 107
section Bailout
This PR (8793) - mean (105ms) : 100, 110
master - mean (103ms) : 99, 107
section CallTarget+Inlining+NGEN
This PR (8793) - mean (951ms) : 915, 987
master - mean (945ms) : 907, 983
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (100ms) : 96, 103
master - mean (99ms) : 96, 102
section Bailout
This PR (8793) - mean (100ms) : 98, 103
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8793) - mean (825ms) : 782, 868
master - mean (820ms) : 783, 856
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (200ms) : 196, 204
master - mean (198ms) : 193, 202
section Bailout
This PR (8793) - mean (203ms) : 199, 206
master - mean (202ms) : 198, 206
section CallTarget+Inlining+NGEN
This PR (8793) - mean (1,196ms) : 1146, 1246
master - mean (1,191ms) : 1155, 1227
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (285ms) : 279, 291
master - mean (283ms) : 276, 290
section Bailout
This PR (8793) - mean (286ms) : 280, 291
master - mean (283ms) : 278, 289
section CallTarget+Inlining+NGEN
This PR (8793) - mean (958ms) : 938, 979
master - mean (955ms) : 934, 976
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (281ms) : 275, 286
master - mean (277ms) : 272, 283
section Bailout
This PR (8793) - mean (279ms) : 273, 284
master - mean (277ms) : 272, 283
section CallTarget+Inlining+NGEN
This PR (8793) - mean (1,156ms) : 1117, 1194
master - mean (1,153ms) : 1114, 1192
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8793) - mean (277ms) : 272, 281
master - mean (275ms) : 269, 280
section Bailout
This PR (8793) - mean (276ms) : 271, 281
master - mean (276ms) : 270, 281
section CallTarget+Inlining+NGEN
This PR (8793) - mean (1,034ms) : 991, 1077
master - mean (1,036ms) : 989, 1082
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Fixes a source of flake in the profiling CI
Reason for change
The sample app was flaky - it was waiting for an arbitrary 100ms before trying to read the URLs of the app. If the app had not initialized, it would read an invalid value (port
0) and crash.Implementation details
Use the "correct" approach, the same as other apps do (e.g. Samples.BuggyBits)
Test coverage
This is the test, if it works, then hopefully less flake in the future.
Other details
I did a check for any other incorrect usages, and it all looks ok.