Trim experimental features flags#8789
Merged
Merged
Conversation
andrewlock
added
the
area:tracer
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8789) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (74ms) : 70, 79
master - mean (72ms) : 69, 75
section Bailout
This PR (8789) - mean (78ms) : 74, 81
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8789) - mean (1,090ms) : 1047, 1132
master - mean (1,098ms) : 1048, 1147
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (116ms) : 109, 122
master - mean (113ms) : 109, 117
section Bailout
This PR (8789) - mean (114ms) : 111, 117
master - mean (116ms) : 111, 122
section CallTarget+Inlining+NGEN
This PR (8789) - mean (797ms) : 769, 825
master - mean (792ms) : 772, 812
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (100ms) : 97, 103
master - mean (100ms) : 97, 104
section Bailout
This PR (8789) - mean (104ms) : 100, 108
master - mean (104ms) : 100, 108
section CallTarget+Inlining+NGEN
This PR (8789) - mean (944ms) : 911, 977
master - mean (945ms) : 894, 996
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (99ms) : 96, 103
master - mean (99ms) : 95, 102
section Bailout
This PR (8789) - mean (101ms) : 99, 103
master - mean (99ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8789) - mean (826ms) : 782, 869
master - mean (824ms) : 779, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (198ms) : 193, 203
master - mean (197ms) : 193, 202
section Bailout
This PR (8789) - mean (202ms) : 198, 206
master - mean (201ms) : 198, 205
section CallTarget+Inlining+NGEN
This PR (8789) - mean (1,195ms) : 1144, 1245
master - mean (1,187ms) : 1149, 1226
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (282ms) : 273, 292
master - mean (282ms) : 277, 287
section Bailout
This PR (8789) - mean (284ms) : 278, 291
master - mean (283ms) : 279, 288
section CallTarget+Inlining+NGEN
This PR (8789) - mean (961ms) : 934, 987
master - mean (958ms) : 935, 981
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (276ms) : 269, 283
master - mean (277ms) : 268, 285
section Bailout
This PR (8789) - mean (276ms) : 271, 282
master - mean (276ms) : 269, 284
section CallTarget+Inlining+NGEN
This PR (8789) - mean (1,154ms) : 1112, 1197
master - mean (1,157ms) : 1133, 1181
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8789) - mean (274ms) : 268, 281
master - mean (277ms) : 271, 283
section Bailout
This PR (8789) - mean (275ms) : 269, 281
master - mean (278ms) : 271, 285
section CallTarget+Inlining+NGEN
This PR (8789) - mean (1,034ms) : 996, 1073
master - mean (1,039ms) : 998, 1080
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
force-pushed
the
andrew/trim-experimental-flags
branch
from
June 15, 2026 15:39
13b2266 to
73b7ce1
Compare
BenchmarksBenchmark execution time: 2026-06-15 17:04:17 Comparing candidate commit 73b7ce1 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
bouwkast
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Trims the "experimental features" entries, to ensure later comparisons aren't impacted
Reason for change
If we have multiple entries and they have whitespace, e.g.
DD_TAGS , DD_SOME_FEATURE, then the individual tags aren't trimmed:DD_TAGSDD_SOME_FEATUREAnd the
Contains()calls will fail, and it won't be obvious why, so just trim.Implementation details
Add a
Trim()when parsing the entries inTraceSettingsTest coverage
Unit test for coverage