Remove debugging blocks leaking environment variables in tests#8781
Merged
Conversation
andrewlock
changed the title
andrewlock
approved these changes
Jun 11, 2026
bouwkast
approved these changes
Jun 11, 2026
This comment has been minimized.
This comment has been minimized.
BenchmarksBenchmark execution time: 2026-06-11 15:46:19 Comparing candidate commit a273270 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 57 known flaky benchmarks, 69 flaky benchmarks without significant changes.
|
The builds aren't showing up so just re-pushing to cause a rebuild
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8781) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (73ms) : 70, 75
master - mean (73ms) : 70, 77
section Bailout
This PR (8781) - mean (80ms) : 75, 84
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8781) - mean (1,107ms) : 1034, 1179
master - mean (1,095ms) : 1041, 1150
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (115ms) : 109, 122
master - mean (114ms) : 108, 120
section Bailout
This PR (8781) - mean (116ms) : 112, 121
master - mean (113ms) : 111, 116
section CallTarget+Inlining+NGEN
This PR (8781) - mean (793ms) : 763, 823
master - mean (793ms) : 767, 818
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (103ms) : 97, 109
master - mean (100ms) : 96, 104
section Bailout
This PR (8781) - mean (102ms) : 99, 106
master - mean (103ms) : 99, 108
section CallTarget+Inlining+NGEN
This PR (8781) - mean (947ms) : 909, 984
master - mean (944ms) : 902, 986
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (99ms) : 95, 103
master - mean (99ms) : 95, 102
section Bailout
This PR (8781) - mean (103ms) : 98, 108
master - mean (99ms) : 97, 101
section CallTarget+Inlining+NGEN
This PR (8781) - mean (824ms) : 781, 866
master - mean (821ms) : 782, 860
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (201ms) : 195, 206
master - mean (200ms) : 192, 207
section Bailout
This PR (8781) - mean (203ms) : 199, 208
master - mean (203ms) : 198, 208
section CallTarget+Inlining+NGEN
This PR (8781) - mean (1,209ms) : 1159, 1259
master - mean (1,198ms) : 1157, 1240
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (286ms) : 279, 294
master - mean (284ms) : 277, 292
section Bailout
This PR (8781) - mean (286ms) : 282, 291
master - mean (286ms) : 281, 291
section CallTarget+Inlining+NGEN
This PR (8781) - mean (961ms) : 941, 982
master - mean (959ms) : 940, 978
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (281ms) : 276, 286
master - mean (279ms) : 274, 284
section Bailout
This PR (8781) - mean (281ms) : 274, 287
master - mean (278ms) : 274, 283
section CallTarget+Inlining+NGEN
This PR (8781) - mean (1,163ms) : 1125, 1200
master - mean (1,160ms) : 1125, 1196
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8781) - mean (278ms) : 272, 284
master - mean (276ms) : 270, 281
section Bailout
This PR (8781) - mean (278ms) : 272, 283
master - mean (277ms) : 273, 280
section CallTarget+Inlining+NGEN
This PR (8781) - mean (1,045ms) : 1004, 1086
master - mean (1,040ms) : 1003, 1078
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bouwkast
enabled auto-merge (squash)
June 11, 2026 16:28
zacharycmontoya
pushed a commit
that referenced
this pull request
Jun 16, 2026
## Summary of changes
This PR removes blocks that can leak environment variables.
## Reason for change
## Implementation details
## Test coverage
## Other details
<!-- Fixes #{issue} -->
<!-- ⚠️ Note:
Where possible, please obtain 2 approvals prior to merging. Unless
CODEOWNERS specifies otherwise, for external teams it is typically best
to have one review from a team member, and one review from apm-dotnet.
Trivial changes do not require 2 reviews.
MergeQueue is NOT enabled in this repository. If you have write access
to the repo, the PR has 1-2 approvals (see above), and all of the
required checks have passed, you can use the Squash and Merge button to
merge the PR. If you don't have write access, or you need help, reach
out in the #apm-dotnet channel in Slack.
-->
---------
Co-authored-by: Andrew Lock <[email protected]>
Co-authored-by: Steven Bouwkamp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR removes blocks that can leak environment variables.
Reason for change
Implementation details
Test coverage
Other details