Flaky test fixing#8760
Merged
Merged
Conversation
github-actions
Bot
added
the
area:profiler
gleocadie
marked this pull request as ready for review
June 5, 2026 15:19
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 763cf756f8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-06-05 16:23:09 Comparing candidate commit c11a958 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8760) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (73ms) : 70, 75
master - mean (74ms) : 70, 79
section Bailout
This PR (8760) - mean (80ms) : 75, 85
master - mean (77ms) : 75, 80
section CallTarget+Inlining+NGEN
This PR (8760) - mean (1,113ms) : 1065, 1160
master - mean (1,106ms) : 1050, 1161
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (115ms) : 110, 121
master - mean (114ms) : 108, 121
section Bailout
This PR (8760) - mean (116ms) : 112, 119
master - mean (113ms) : 111, 116
section CallTarget+Inlining+NGEN
This PR (8760) - mean (795ms) : 771, 818
master - mean (793ms) : 760, 825
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (104ms) : 96, 112
master - mean (101ms) : 98, 105
section Bailout
This PR (8760) - mean (105ms) : 100, 111
master - mean (102ms) : 99, 105
section CallTarget+Inlining+NGEN
This PR (8760) - mean (957ms) : 924, 990
master - mean (948ms) : 905, 991
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (99ms) : 95, 103
master - mean (101ms) : 96, 106
section Bailout
This PR (8760) - mean (103ms) : 99, 108
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8760) - mean (826ms) : 790, 863
master - mean (824ms) : 778, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (198ms) : 193, 204
master - mean (196ms) : 192, 200
section Bailout
This PR (8760) - mean (204ms) : 201, 207
master - mean (200ms) : 196, 203
section CallTarget+Inlining+NGEN
This PR (8760) - mean (1,196ms) : 1159, 1232
master - mean (1,196ms) : 1159, 1232
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (285ms) : 277, 293
master - mean (285ms) : 278, 292
section Bailout
This PR (8760) - mean (286ms) : 281, 292
master - mean (283ms) : 277, 290
section CallTarget+Inlining+NGEN
This PR (8760) - mean (963ms) : 941, 986
master - mean (956ms) : 934, 979
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (278ms) : 272, 284
master - mean (276ms) : 269, 283
section Bailout
This PR (8760) - mean (276ms) : 270, 282
master - mean (275ms) : 270, 280
section CallTarget+Inlining+NGEN
This PR (8760) - mean (1,163ms) : 1120, 1206
master - mean (1,161ms) : 1128, 1194
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8760) - mean (276ms) : 268, 284
master - mean (277ms) : 268, 287
section Bailout
This PR (8760) - mean (277ms) : 271, 282
master - mean (276ms) : 270, 283
section CallTarget+Inlining+NGEN
This PR (8760) - mean (1,043ms) : 997, 1090
master - mean (1,038ms) : 993, 1083
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
gleocadie
enabled auto-merge (squash)
June 5, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix flaky test
Reason for change
We have test failing because the ASP.NET Core app failed to bind to a specific port.
Implementation details
Let kestrel decides which port to use and parse the application output to get it for the tests.
Test coverage
Nothing more to do.
Other details