Exclude InMemoryAssembly from dependency collection#8759
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8759) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (74ms) : 71, 77
master - mean (74ms) : 70, 79
section Bailout
This PR (8759) - mean (77ms) : 75, 79
master - mean (77ms) : 75, 80
section CallTarget+Inlining+NGEN
This PR (8759) - mean (1,118ms) : 1055, 1180
master - mean (1,106ms) : 1050, 1161
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (114ms) : 109, 119
master - mean (114ms) : 108, 121
section Bailout
This PR (8759) - mean (117ms) : 111, 123
master - mean (113ms) : 111, 116
section CallTarget+Inlining+NGEN
This PR (8759) - mean (801ms) : 776, 826
master - mean (793ms) : 760, 825
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (102ms) : 98, 105
master - mean (101ms) : 98, 105
section Bailout
This PR (8759) - mean (106ms) : 99, 112
master - mean (102ms) : 99, 105
section CallTarget+Inlining+NGEN
This PR (8759) - mean (958ms) : 923, 994
master - mean (948ms) : 905, 991
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (100ms) : 95, 104
master - mean (101ms) : 96, 106
section Bailout
This PR (8759) - mean (101ms) : 98, 104
master - mean (100ms) : 97, 102
section CallTarget+Inlining+NGEN
This PR (8759) - mean (827ms) : 782, 872
master - mean (824ms) : 778, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (200ms) : 194, 205
master - mean (196ms) : 192, 200
section Bailout
This PR (8759) - mean (202ms) : 197, 207
master - mean (200ms) : 196, 203
section CallTarget+Inlining+NGEN
This PR (8759) - mean (1,209ms) : 1148, 1270
master - mean (1,196ms) : 1159, 1232
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (290ms) : 283, 296
master - mean (285ms) : 278, 292
section Bailout
This PR (8759) - mean (289ms) : 283, 296
master - mean (283ms) : 277, 290
section CallTarget+Inlining+NGEN
This PR (8759) - mean (969ms) : 948, 990
master - mean (956ms) : 934, 979
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (281ms) : 274, 289
master - mean (276ms) : 269, 283
section Bailout
This PR (8759) - mean (279ms) : 272, 287
master - mean (275ms) : 270, 280
section CallTarget+Inlining+NGEN
This PR (8759) - mean (1,157ms) : 1115, 1199
master - mean (1,161ms) : 1128, 1194
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8759) - mean (278ms) : 271, 284
master - mean (277ms) : 268, 287
section Bailout
This PR (8759) - mean (278ms) : 272, 283
master - mean (276ms) : 270, 283
section CallTarget+Inlining+NGEN
This PR (8759) - mean (1,038ms) : 1000, 1076
master - mean (1,038ms) : 993, 1083
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-06-05 15:10:02 Comparing candidate commit f1aed04 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 62 known flaky benchmarks, 64 flaky benchmarks without significant changes.
|
## Summary of changes exclude assemblies called `InMemoryAssembly` from dependency version collection ## Reason for change These are dynamically emitted assemblies, with high cardinality, so we should skip them ## Implementation details Add `InMemoryAssembly` to the list of excluded assemblies ## Test coverage Added a unit test ## Other details Fixes https://datadoghq.atlassian.net/browse/K9VULN-15902
Summary of changes
exclude assemblies called
InMemoryAssemblyfrom dependency version collectionReason for change
These are dynamically emitted assemblies, with high cardinality, so we should skip them
Implementation details
Add
InMemoryAssemblyto the list of excluded assembliesTest coverage
Added a unit test
Other details
Fixes https://datadoghq.atlassian.net/browse/K9VULN-15902