[Profiler] Measure LibrariesInfoCache performance#8757
Merged
gleocadie merged 7 commits intoJun 10, 2026
Conversation
github-actions
Bot
added
the
area:profiler
gleocadie
force-pushed
the
gleocadie/measure-libraries-info-cache-performance
branch
from
June 5, 2026 10:00
9e35ac2 to
e194b7d
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8757) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (74ms) : 70, 79
master - mean (73ms) : 69, 78
section Bailout
This PR (8757) - mean (77ms) : 75, 79
master - mean (77ms) : 75, 79
section CallTarget+Inlining+NGEN
This PR (8757) - mean (1,102ms) : 1047, 1157
master - mean (1,098ms) : 1045, 1151
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (116ms) : 109, 123
master - mean (114ms) : 108, 119
section Bailout
This PR (8757) - mean (114ms) : 111, 117
master - mean (114ms) : 110, 117
section CallTarget+Inlining+NGEN
This PR (8757) - mean (804ms) : 769, 839
master - mean (792ms) : 769, 815
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (101ms) : 98, 104
master - mean (100ms) : 97, 104
section Bailout
This PR (8757) - mean (102ms) : 99, 104
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8757) - mean (948ms) : 904, 992
master - mean (947ms) : 903, 991
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (102ms) : 97, 108
master - mean (100ms) : 95, 104
section Bailout
This PR (8757) - mean (101ms) : 97, 105
master - mean (100ms) : 98, 103
section CallTarget+Inlining+NGEN
This PR (8757) - mean (828ms) : 780, 875
master - mean (824ms) : 787, 862
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (199ms) : 195, 203
master - mean (197ms) : 193, 201
section Bailout
This PR (8757) - mean (203ms) : 200, 207
master - mean (201ms) : 198, 204
section CallTarget+Inlining+NGEN
This PR (8757) - mean (1,197ms) : 1157, 1236
master - mean (1,198ms) : 1154, 1243
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (282ms) : 277, 288
master - mean (282ms) : 276, 288
section Bailout
This PR (8757) - mean (283ms) : 278, 288
master - mean (281ms) : 273, 289
section CallTarget+Inlining+NGEN
This PR (8757) - mean (957ms) : 937, 978
master - mean (955ms) : 933, 976
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (275ms) : 268, 281
master - mean (275ms) : 271, 279
section Bailout
This PR (8757) - mean (276ms) : 268, 284
master - mean (275ms) : 270, 280
section CallTarget+Inlining+NGEN
This PR (8757) - mean (1,156ms) : 1113, 1199
master - mean (1,155ms) : 1125, 1186
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8757) - mean (272ms) : 264, 280
master - mean (275ms) : 268, 281
section Bailout
This PR (8757) - mean (273ms) : 267, 278
master - mean (274ms) : 267, 280
section CallTarget+Inlining+NGEN
This PR (8757) - mean (1,036ms) : 990, 1082
master - mean (1,034ms) : 992, 1076
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-06-10 14:31:56 Comparing candidate commit fbfa097 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
gleocadie
force-pushed
the
gleocadie/measure-libraries-info-cache-performance
branch
from
June 9, 2026 08:38
af8c242 to
6c6dd0d
Compare
This comment has been minimized.
This comment has been minimized.
gleocadie
marked this pull request as ready for review
June 10, 2026 13:07
gleocadie
force-pushed
the
gleocadie/measure-libraries-info-cache-performance
branch
from
June 10, 2026 13:09
1683512 to
34fc14a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1683512cdc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
zacharycmontoya
pushed a commit
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add metrics to measure the cpu and memory consumption of the
LibrariesInfoCacheReason for change
We are add caches to the
LibrariesInfoCacheand we need to measure and watch the memory consumption.Implementation details
Add a
FootprintTrackerto track the cpu, memory.Use
MetricsRegistryto report them as profiling metrics.Test coverage
The tests we have should suffice.
Other details