Skip to content

[CI] Retry docker pull of ddapm-test-agent image on transient failure#8755

Merged
NachoEchevarria merged 1 commit into
masterfrom
nacho/retryDockerPull
Jun 10, 2026
Merged

[CI] Retry docker pull of ddapm-test-agent image on transient failure#8755
NachoEchevarria merged 1 commit into
masterfrom
nacho/retryDockerPull

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Add retryCountOnTaskFailure: 3 to both docker pull ddapm-test-agent:latest steps (x64 and ARM64) in ultimate-pipeline.yml.

Reason for change

These standalone script steps had no retry, so a transient registry/network error during the pull (e.g. failed to copy: failed to send write: EOF) failed the whole job. Retry mechanisms exist elsewhere in the pipeline (retryCountOnTaskFailure, retryCountForRunCommand) but were never wired into these two steps.

Implementation details

retryCountOnTaskFailure is the native Azure DevOps step-level retry; it re-runs the step up to 3 times on failure.

Test coverage

N/A — CI configuration change.

Other details

@NachoEchevarria NachoEchevarria changed the title Update ultimate-pipeline.yml [CI] Retry docker pull of ddapm-test-agent image on transient failure Jun 5, 2026
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jun 5, 2026
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8755) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.96 ± (74.15 - 74.76) ms74.19 ± (74.29 - 74.71) ms+0.3%✅⬆️
.NET Framework 4.8 - Bailout
duration76.99 ± (76.92 - 77.31) ms77.26 ± (77.08 - 77.49) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1102.24 ± (1101.13 - 1110.18) ms1108.65 ± (1108.08 - 1115.43) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.53 ± (22.49 - 22.58) ms22.51 ± (22.46 - 22.55) ms-0.1%
process.time_to_main_ms84.84 ± (84.55 - 85.12) ms84.09 ± (83.91 - 84.27) ms-0.9%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.93 ± (10.92 - 10.93) MB10.92 ± (10.92 - 10.92) MB-0.1%
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.31 ± (22.27 - 22.34) ms22.36 ± (22.33 - 22.40) ms+0.3%✅⬆️
process.time_to_main_ms84.54 ± (84.33 - 84.74) ms84.99 ± (84.81 - 85.16) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.95 ± (10.95 - 10.96) MB-0.1%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms214.03 ± (213.19 - 214.87) ms213.18 ± (212.43 - 213.94) ms-0.4%
process.time_to_main_ms543.24 ± (541.87 - 544.60) ms540.41 ± (539.24 - 541.57) ms-0.5%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.36 ± (48.33 - 48.39) MB48.42 ± (48.40 - 48.45) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.25 ± (21.22 - 21.28) ms21.50 ± (21.45 - 21.55) ms+1.2%✅⬆️
process.time_to_main_ms73.57 ± (73.39 - 73.74) ms76.14 ± (75.89 - 76.40) ms+3.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.62 ± (10.61 - 10.62) MB10.66 ± (10.66 - 10.66) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.10 ± (21.06 - 21.13) ms21.21 ± (21.17 - 21.26) ms+0.6%✅⬆️
process.time_to_main_ms74.42 ± (74.23 - 74.61) ms75.54 ± (75.34 - 75.73) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.73 ± (10.73 - 10.73) MB10.76 ± (10.76 - 10.77) MB+0.3%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms371.26 ± (368.78 - 373.74) ms371.87 ± (369.68 - 374.07) ms+0.2%✅⬆️
process.time_to_main_ms546.45 ± (545.13 - 547.78) ms550.65 ± (549.33 - 551.98) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed49.77 ± (49.75 - 49.80) MB49.80 ± (49.78 - 49.83) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%
.NET 8 - Baseline
process.internal_duration_ms19.47 ± (19.42 - 19.52) ms19.46 ± (19.41 - 19.50) ms-0.1%
process.time_to_main_ms73.60 ± (73.35 - 73.86) ms73.10 ± (72.87 - 73.33) ms-0.7%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.69 ± (7.69 - 7.70) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.25 ± (19.23 - 19.28) ms19.69 ± (19.64 - 19.74) ms+2.3%✅⬆️
process.time_to_main_ms72.85 ± (72.69 - 73.02) ms75.65 ± (75.43 - 75.86) ms+3.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.73 ± (7.73 - 7.74) MB7.75 ± (7.74 - 7.75) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms297.77 ± (295.57 - 299.96) ms293.63 ± (291.46 - 295.80) ms-1.4%
process.time_to_main_ms494.47 ± (493.32 - 495.62) ms496.79 ± (495.78 - 497.81) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.80 ± (36.77 - 36.84) MB36.93 ± (36.90 - 36.96) MB+0.3%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.8%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration195.90 ± (195.82 - 196.64) ms197.56 ± (197.47 - 198.28) ms+0.8%✅⬆️
.NET Framework 4.8 - Bailout
duration199.83 ± (199.48 - 200.18) ms201.73 ± (201.49 - 202.22) ms+1.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1193.29 ± (1192.88 - 1198.25) ms1194.58 ± (1195.51 - 1201.21) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms192.40 ± (191.95 - 192.85) ms192.56 ± (192.12 - 193.00) ms+0.1%✅⬆️
process.time_to_main_ms83.11 ± (82.82 - 83.39) ms83.76 ± (83.44 - 84.09) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.10 ± (16.07 - 16.12) MB16.12 ± (16.09 - 16.15) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms190.93 ± (190.47 - 191.38) ms192.52 ± (192.11 - 192.94) ms+0.8%✅⬆️
process.time_to_main_ms83.78 ± (83.53 - 84.03) ms84.51 ± (84.25 - 84.78) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.15 ± (16.12 - 16.18) MB16.16 ± (16.13 - 16.19) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.7%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms385.14 ± (383.84 - 386.43) ms385.28 ± (384.17 - 386.39) ms+0.0%✅⬆️
process.time_to_main_ms531.49 ± (530.20 - 532.77) ms534.54 ± (533.37 - 535.72) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed57.23 ± (57.07 - 57.40) MB57.50 ± (57.32 - 57.68) MB+0.5%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms195.48 ± (195.01 - 195.96) ms195.59 ± (195.19 - 195.99) ms+0.1%✅⬆️
process.time_to_main_ms72.02 ± (71.77 - 72.28) ms71.88 ± (71.63 - 72.13) ms-0.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.36 ± (16.33 - 16.39) MB16.45 ± (16.41 - 16.48) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms193.96 ± (193.63 - 194.29) ms195.33 ± (194.93 - 195.73) ms+0.7%✅⬆️
process.time_to_main_ms72.57 ± (72.40 - 72.74) ms73.05 ± (72.84 - 73.27) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.44 ± (16.41 - 16.46) MB16.47 ± (16.44 - 16.50) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms587.59 ± (585.24 - 589.94) ms583.65 ± (581.16 - 586.14) ms-0.7%
process.time_to_main_ms540.31 ± (539.29 - 541.33) ms538.74 ± (537.70 - 539.77) ms-0.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed61.12 ± (61.02 - 61.22) MB61.04 ± (60.96 - 61.12) MB-0.1%
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.1%
.NET 8 - Baseline
process.internal_duration_ms195.39 ± (194.88 - 195.90) ms194.54 ± (194.06 - 195.02) ms-0.4%
process.time_to_main_ms71.73 ± (71.47 - 71.98) ms71.46 ± (71.22 - 71.71) ms-0.4%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.73) MB11.74 ± (11.72 - 11.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.5%
.NET 8 - Bailout
process.internal_duration_ms193.70 ± (193.22 - 194.17) ms194.40 ± (193.87 - 194.93) ms+0.4%✅⬆️
process.time_to_main_ms72.55 ± (72.30 - 72.81) ms72.82 ± (72.57 - 73.08) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.76 ± (11.74 - 11.78) MB11.80 ± (11.78 - 11.83) MB+0.4%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.2%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms516.89 ± (514.36 - 519.42) ms516.06 ± (513.43 - 518.70) ms-0.2%
process.time_to_main_ms488.24 ± (487.46 - 489.03) ms493.63 ± (492.78 - 494.49) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed50.61 ± (50.58 - 50.64) MB50.63 ± (50.59 - 50.66) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (29 - 30)+0.8%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (75ms)  : 71, 78
    master - mean (74ms)  : 70, 79

    section Bailout
    This PR (8755) - mean (77ms)  : 75, 80
    master - mean (77ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (1,112ms)  : 1060, 1164
    master - mean (1,106ms)  : 1050, 1161

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (114ms)  : 110, 117
    master - mean (114ms)  : 108, 121

    section Bailout
    This PR (8755) - mean (114ms)  : 112, 116
    master - mean (113ms)  : 111, 116

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (789ms)  : 761, 817
    master - mean (793ms)  : 760, 825

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (104ms)  : 99, 110
    master - mean (101ms)  : 98, 105

    section Bailout
    This PR (8755) - mean (103ms)  : 101, 105
    master - mean (102ms)  : 99, 105

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (950ms)  : 913, 987
    master - mean (948ms)  : 905, 991

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (101ms)  : 96, 105
    master - mean (101ms)  : 96, 106

    section Bailout
    This PR (8755) - mean (103ms)  : 99, 108
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (820ms)  : 786, 853
    master - mean (824ms)  : 778, 869

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (198ms)  : 194, 202
    master - mean (196ms)  : 192, 200

    section Bailout
    This PR (8755) - mean (202ms)  : 198, 205
    master - mean (200ms)  : 196, 203

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (1,198ms)  : 1158, 1239
    master - mean (1,196ms)  : 1159, 1232

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (285ms)  : 279, 292
    master - mean (285ms)  : 278, 292

    section Bailout
    This PR (8755) - mean (286ms)  : 280, 291
    master - mean (283ms)  : 277, 290

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (960ms)  : 943, 977
    master - mean (956ms)  : 934, 979

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (276ms)  : 271, 281
    master - mean (276ms)  : 269, 283

    section Bailout
    This PR (8755) - mean (277ms)  : 272, 282
    master - mean (275ms)  : 270, 280

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (1,152ms)  : 1115, 1189
    master - mean (1,161ms)  : 1128, 1194

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8755) - mean (276ms)  : 268, 284
    master - mean (277ms)  : 268, 287

    section Bailout
    This PR (8755) - mean (277ms)  : 270, 284
    master - mean (276ms)  : 270, 283

    section CallTarget+Inlining+NGEN
    This PR (8755) - mean (1,041ms)  : 993, 1089
    master - mean (1,038ms)  : 993, 1083

Loading

@pr-commenter

pr-commenter Bot commented Jun 5, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-05 09:51:57

Comparing candidate commit 7e79c6e in PR branch nacho/retryDockerPull with baseline commit 44f05b7 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-6021.716op/s; -5525.174op/s] or [-6.874%; -6.307%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-7945.092op/s; -7503.177op/s] or [-9.421%; -8.897%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-8321.514op/s; -7013.727op/s] or [-8.461%; -7.131%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+309.541ms; +317.715ms] or [+153.605%; +157.661%]
  • 🟥 throughput [-42.035op/s; -38.448op/s] or [-7.563%; -6.917%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+380.424ms; +382.167ms] or [+300.558%; +301.935%]
  • 🟩 throughput [+90.714op/s; +93.661op/s] or [+11.960%; +12.349%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+393.648ms; +396.710ms] or [+348.364%; +351.073%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-16.814ms; -12.550ms] or [-7.853%; -5.861%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-272425.052op/s; -269086.415op/s] or [-27.816%; -27.475%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.673ms; -21.837ms] or [-11.895%; -9.738%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-161925.285op/s; -145498.577op/s] or [-23.266%; -20.905%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+8079.676op/s; +11076.038op/s] or [+5.141%; +7.048%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+9732.226op/s; +12383.790op/s] or [+7.753%; +9.865%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+424503.466op/s; +458988.823op/s] or [+14.155%; +15.305%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.866ms; -14.479ms] or [-8.696%; -6.674%]
  • 🟩 throughput [+176631.300op/s; +231234.006op/s] or [+7.011%; +9.178%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.679ms; +300.557ms] or [+149.739%; +150.178%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+300.491ms; +303.652ms] or [+151.538%; +153.132%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+301.254ms; +304.097ms] or [+151.748%; +153.180%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.102ms; +296.941ms] or [+145.434%; +145.845%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+293.811ms; +297.897ms] or [+143.633%; +145.631%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+303.527ms; +306.548ms] or [+151.702%; +153.212%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟥 execution_time [+27.301µs; +55.132µs] or [+6.261%; +12.645%]
  • 🟥 throughput [-265.059op/s; -140.240op/s] or [-11.524%; -6.097%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+23.739µs; +47.435µs] or [+7.579%; +15.143%]
  • 🟥 throughput [-440.156op/s; -240.793op/s] or [-13.721%; -7.506%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.055ms; +300.758ms] or [+149.758%; +150.109%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+340.887ms; +405.921ms] or [+370.387%; +441.050%]
  • 🟩 throughput [+806.197op/s; +1036.389op/s] or [+6.625%; +8.516%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+297.029ms; +350.531ms] or [+225.532%; +266.155%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+318.414ms; +365.878ms] or [+146.403%; +168.227%]
  • 🟥 throughput [-520.122op/s; -476.704op/s] or [-47.128%; -43.194%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+210.531ms; +343.803ms] or [+89.720%; +146.514%]
  • 🟥 throughput [-671.899op/s; -588.355op/s] or [-44.816%; -39.243%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+328.616ms; +337.022ms] or [+196.551%; +201.578%]
  • 🟥 throughput [-398.136op/s; -362.041op/s] or [-27.722%; -25.208%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+305.529ms; +307.397ms] or [+153.858%; +154.799%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+301.406ms; +304.383ms] or [+151.035%; +152.527%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+302.686ms; +306.819ms] or [+152.057%; +154.133%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+301.792ms; +304.605ms] or [+151.550%; +152.962%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+300.138ms; +302.156ms] or [+148.405%; +149.403%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.101ms; +305.716ms] or [+153.118%; +154.950%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+299.034ms; +300.841ms] or [+150.088%; +150.995%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+302.017ms; +304.403ms] or [+150.528%; +151.717%]
  • 🟩 throughput [+37854.390op/s; +47083.397op/s] or [+7.517%; +9.349%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+299.223ms; +301.668ms] or [+148.861%; +150.077%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+6.617µs; +50.473µs] or [+1.635%; +12.467%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.983KB; -19.961KB] or [-7.289%; -7.281%]
  • unstable execution_time [-39.699µs; +13.778µs] or [-7.846%; +2.723%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-19.213KB; -19.195KB] or [-7.004%; -6.997%]
  • unstable execution_time [-65.507µs; -4.254µs] or [-11.352%; -0.737%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+8.764µs; +14.303µs] or [+20.715%; +33.807%]
  • 🟥 throughput [-5885.248op/s; -3846.260op/s] or [-24.775%; -16.192%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.375µs; -3.699µs] or [-20.750%; -5.739%]
  • unstable throughput [+1184.138op/s; +3058.119op/s] or [+7.265%; +18.763%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.082ms; +303.448ms] or [+152.689%; +153.379%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.529ms; +306.010ms] or [+153.986%; +155.758%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.887ms; +303.418ms] or [+150.631%; +151.898%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+26450.067op/s; +28578.323op/s] or [+5.006%; +5.409%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.391ms; +302.666ms] or [+149.718%; +150.852%]
  • 🟥 throughput [-11775.678op/s; -10527.431op/s] or [-7.776%; -6.951%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+299.779ms; +301.406ms] or [+150.535%; +151.352%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.556ms; +304.932ms] or [+153.437%; +154.642%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.085ms; +300.945ms] or [+149.684%; +150.113%]
  • 🟩 throughput [+61021812.927op/s; +61342500.088op/s] or [+44.440%; +44.673%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+419.362ms; +423.591ms] or [+521.551%; +526.811%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.762ms; +300.858ms] or [+149.514%; +150.061%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+82067.159op/s; +89741.485op/s] or [+7.662%; +8.379%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+49056.120op/s; +68170.752op/s] or [+5.678%; +7.891%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+66330.613op/s; +102592.220op/s] or [+5.134%; +7.941%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+79362.881op/s; +87412.392op/s] or [+7.882%; +8.681%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+48403.646op/s; +54044.818op/s] or [+8.789%; +9.814%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+78990.927op/s; +99065.351op/s] or [+8.825%; +11.068%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@NachoEchevarria
NachoEchevarria marked this pull request as ready for review June 5, 2026 13:50
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner June 5, 2026 13:50

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should probably pin these and rebuild the VMs sometime soon so that we don't have to pull at all! 😄

@NachoEchevarria
NachoEchevarria merged commit cd4ee4e into master Jun 10, 2026
135 of 136 checks passed
@NachoEchevarria
NachoEchevarria deleted the nacho/retryDockerPull branch June 10, 2026 07:48
@github-actions github-actions Bot added this to the vNext-v3 milestone Jun 10, 2026
zacharycmontoya pushed a commit that referenced this pull request Jun 16, 2026
…#8755)

## Summary of changes

Add `retryCountOnTaskFailure: 3` to both `docker pull
ddapm-test-agent:latest` steps (x64 and ARM64) in
`ultimate-pipeline.yml`.

## Reason for change

These standalone `script` steps had no retry, so [a transient
registry/network
error](https://dev.azure.com/datadoghq/a51c4863-3eb4-4c5d-878a-58b41a049e4e/_apis/build/builds/202885/logs/6041)
during the pull (e.g. `failed to copy: failed to send write: EOF`)
failed the whole job. Retry mechanisms exist elsewhere in the pipeline
(`retryCountOnTaskFailure`, `retryCountForRunCommand`) but were never
wired into these two steps.

## Implementation details

`retryCountOnTaskFailure` is the native Azure DevOps step-level retry;
it re-runs the step up to 3 times on failure.

## Test coverage

N/A — CI configuration change.

## Other details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants