Fixes InvalidProgramException when reading push values outside the boundaries of the array#875
Merged
Merged
Conversation
kevingosse
approved these changes
Aug 21, 2020
lucaspimentel
approved these changes
Aug 21, 2020
Contributor
|
Can you leave a note about what issue this fixes? Otherwise this looks like a trivial change even though this provides a much needed fix. It would also help for better discoverability in the future 😄 |
zacharycmontoya
approved these changes
Aug 21, 2020
tonyredondo
changed the title
tonyredondo
changed the title
Member
Author
|
I’ve changed the PR’s title and description to be more explicit with the fix. |
zacharycmontoya
added
area:native-library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a possible InvalidProgramException when the IL method body contains switch statements due to invalid maxstack header value by reading outside the boundaries of the push values array. To mitigate this we add the missing values to the array.
Changes:
CEE_COUNTandCEE_SWITCH_ARG@DataDog/apm-dotnet