[Profiler] fix flacky tests#8745
Merged
Merged
Conversation
github-actions
Bot
added
the
area:profiler
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8745) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (74ms) : 71, 77
master - mean (74ms) : 71, 78
section Bailout
This PR (8745) - mean (78ms) : 76, 79
master - mean (78ms) : 75, 80
section CallTarget+Inlining+NGEN
This PR (8745) - mean (1,113ms) : 1050, 1177
master - mean (1,105ms) : 1051, 1158
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (114ms) : 108, 119
master - mean (115ms) : 109, 121
section Bailout
This PR (8745) - mean (114ms) : 111, 116
master - mean (115ms) : 112, 118
section CallTarget+Inlining+NGEN
This PR (8745) - mean (798ms) : 778, 818
master - mean (798ms) : 772, 824
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (100ms) : 96, 105
master - mean (101ms) : 96, 105
section Bailout
This PR (8745) - mean (104ms) : 97, 110
master - mean (104ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8745) - mean (952ms) : 909, 994
master - mean (944ms) : 904, 985
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (100ms) : 94, 106
master - mean (99ms) : 95, 103
section Bailout
This PR (8745) - mean (100ms) : 98, 102
master - mean (100ms) : 98, 102
section CallTarget+Inlining+NGEN
This PR (8745) - mean (824ms) : 787, 862
master - mean (821ms) : 780, 862
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (197ms) : 191, 204
master - mean (199ms) : 192, 206
section Bailout
This PR (8745) - mean (200ms) : 195, 206
master - mean (204ms) : 199, 208
section CallTarget+Inlining+NGEN
This PR (8745) - mean (1,198ms) : 1140, 1255
master - mean (1,201ms) : 1156, 1246
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (284ms) : 277, 290
master - mean (288ms) : 281, 294
section Bailout
This PR (8745) - mean (284ms) : 278, 290
master - mean (289ms) : 283, 294
section CallTarget+Inlining+NGEN
This PR (8745) - mean (960ms) : 936, 984
master - mean (965ms) : 947, 982
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (277ms) : 271, 282
master - mean (281ms) : 275, 287
section Bailout
This PR (8745) - mean (277ms) : 271, 282
master - mean (280ms) : 276, 283
section CallTarget+Inlining+NGEN
This PR (8745) - mean (1,156ms) : 1110, 1201
master - mean (1,166ms) : 1122, 1210
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8745) - mean (275ms) : 270, 280
master - mean (277ms) : 271, 283
section Bailout
This PR (8745) - mean (277ms) : 272, 282
master - mean (277ms) : 271, 282
section CallTarget+Inlining+NGEN
This PR (8745) - mean (1,037ms) : 992, 1083
master - mean (1,038ms) : 1004, 1072
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-06-04 14:25:21 Comparing candidate commit 5a03008 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 62 known flaky benchmarks, 64 flaky benchmarks without significant changes.
|
chrisnas
force-pushed
the
chrisnas/flacky_tests
branch
from
June 4, 2026 13:33
2c410c9 to
5a03008
Compare
gleocadie
approved these changes
Jun 4, 2026
| // is sparse enough that this coincidence is missed in every window, making the test flaky. | ||
| // Use a single export window (flushed on shutdown, after every span has closed) so the association is | ||
| // deterministic on this runtime. | ||
| runner.Environment.SetVariable("DD_PROFILING_UPLOAD_PERIOD", "600"); |
Collaborator
There was a problem hiding this comment.
hum ok, not in this PR, but may be would change
public int ProfilingExportsIntervalInSeconds { get; } = 3;
into
public TimeSpan ProfilingExportsIntervalInSeconds { get; } = TimeSpan.FromSeconds(3);
So in the code instead of setting the env var we could just do
runner.ProfilingExportsIntervalInSeconds = TimeSpan.FromMilliseconds(600);
Contributor
Author
There was a problem hiding this comment.
ok: let's do that more globally in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix flacky tests:
Reason for change
Avoid flacky tests
Implementation details
Test coverage
flacky tests have been updated
Other details