[Config] Add scope field to all existing registry entries (1/3)#8731
Merged
Conversation
bm1549
added
the
AI Generated
This comment has been minimized.
This comment has been minimized.
Adds scope: managed to every entry in supported-configurations.yaml (317 entries). Also adds scope to the YAML parser's recognized property list so the field is accepted without throwing. Updates all existing test YAML fixtures to include scope, and documents the scope field in AddingConfigurationKeys.md. No behavioral change: the generator does not yet act on the scope field — that infrastructure lands in the next PR. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
bm1549
force-pushed
the
brian.marks/native-config-scope-pr1
branch
from
June 2, 2026 17:24
e8fba4e to
9fb89ee
Compare
BenchmarksBenchmark execution time: 2026-06-09 17:25:55 Comparing candidate commit 7ef2072 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 1 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8731) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (74ms) : 72, 76
master - mean (76ms) : 71, 81
section Bailout
This PR (8731) - mean (77ms) : 76, 79
master - mean (79ms) : 76, 81
section CallTarget+Inlining+NGEN
This PR (8731) - mean (1,117ms) : 1064, 1169
master - mean (1,121ms) : 1068, 1174
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (114ms) : 109, 118
master - mean (113ms) : 108, 119
section Bailout
This PR (8731) - mean (118ms) : 112, 125
master - mean (114ms) : 112, 115
section CallTarget+Inlining+NGEN
This PR (8731) - mean (794ms) : 769, 819
master - mean (792ms) : 764, 820
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (106ms) : 102, 110
master - mean (105ms) : 97, 112
section Bailout
This PR (8731) - mean (104ms) : 100, 108
master - mean (106ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (8731) - mean (955ms) : 912, 998
master - mean (955ms) : 909, 1001
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (101ms) : 95, 106
master - mean (100ms) : 97, 103
section Bailout
This PR (8731) - mean (103ms) : 99, 107
master - mean (104ms) : 100, 109
section CallTarget+Inlining+NGEN
This PR (8731) - mean (825ms) : 787, 863
master - mean (829ms) : 788, 871
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (198ms) : 193, 202
master - mean (200ms) : 195, 205
section Bailout
This PR (8731) - mean (202ms) : 199, 205
master - mean (203ms) : 200, 207
section CallTarget+Inlining+NGEN
This PR (8731) - mean (1,195ms) : 1158, 1232
master - mean (1,205ms) : 1155, 1255
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (284ms) : 279, 290
master - mean (288ms) : 281, 294
section Bailout
This PR (8731) - mean (286ms) : 282, 290
master - mean (288ms) : 282, 294
section CallTarget+Inlining+NGEN
This PR (8731) - mean (960ms) : 938, 983
master - mean (963ms) : 945, 980
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (277ms) : 267, 287
master - mean (279ms) : 273, 285
section Bailout
This PR (8731) - mean (278ms) : 267, 289
master - mean (279ms) : 274, 284
section CallTarget+Inlining+NGEN
This PR (8731) - mean (1,151ms) : 1093, 1209
master - mean (1,161ms) : 1126, 1195
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8731) - mean (279ms) : 273, 285
master - mean (278ms) : 272, 283
section Bailout
This PR (8731) - mean (278ms) : 271, 285
master - mean (279ms) : 273, 285
section CallTarget+Inlining+NGEN
This PR (8731) - mean (1,037ms) : 990, 1083
master - mean (1,037ms) : 998, 1076
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anna-git
approved these changes
Jun 3, 2026
bm1549
marked this pull request as ready for review
June 5, 2026 16:09
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fb89ee6f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
zacharycmontoya
pushed a commit
that referenced
this pull request
Jun 16, 2026
## Summary of changes Adds `scope: managed` to every existing entry in `supported-configurations.yaml`. Also adds `scope` to the YAML parser's recognized property list so the field is accepted without throwing. This is the first of three stacked PRs introducing scope tracking to the configuration registry: - **PR 1 (this)**: Add `scope: managed` to all existing entries — pure data + one-line parser guard - [**PR 2**](#8732): Full scope infrastructure — parsing, generator enforcement, tests, docs - [**PR 3**](#8733): All native config variables — new `scope: native` entries + `scope: managed, native` upgrades ## Reason for change Prerequisite for scope-aware config registry. The parser must recognize the field before the data lands; the generator infrastructure lands in PR 2. ## Implementation details - `YamlReader.cs`: one-line addition — `"scope"` added to the recognized property list (prevents `InvalidOperationException` on unknown fields) - `supported-configurations.yaml`: `scope: managed` inserted after every `- implementation:` line across all 317 existing entries No behavioral change — the generator does not yet read or act on the scope field. ## Test coverage Existing test suite passes unchanged. The generator ignores the scope field at this point so no new tests are needed here. ## Other details Part of a larger effort to register all native-consumed `DD_*` variables in the config registry and enforce coverage via a CI test. Co-authored-by: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds
scope: managedto every existing entry insupported-configurations.yaml. Also addsscopeto the YAML parser's recognized property list so the field is accepted without throwing.This is the first of three stacked PRs introducing scope tracking to the configuration registry:
scope: managedto all existing entries — pure data + one-line parser guardscope: nativeentries +scope: managed, nativeupgradesReason for change
Prerequisite for scope-aware config registry. The parser must recognize the field before the data lands; the generator infrastructure lands in PR 2.
Implementation details
YamlReader.cs: one-line addition —"scope"added to the recognized property list (preventsInvalidOperationExceptionon unknown fields)supported-configurations.yaml:scope: managedinserted after every- implementation:line across all 317 existing entriesNo behavioral change — the generator does not yet read or act on the scope field.
Test coverage
Existing test suite passes unchanged. The generator ignores the scope field at this point so no new tests are needed here.
Other details
Part of a larger effort to register all native-consumed
DD_*variables in the config registry and enforce coverage via a CI test.