Fix "CallVirtual expected a StackExchange.Redis.RedisBase; found StackExchange.Redis.RedisBase"#872
Merged
Merged
Conversation
…sync method and using both StackExchange.Redis and StackExchange.Redis.StrongName assemblies
…ch can lead to type issues when both StackExchange.Redis and StackExchange.Redis.StrongName assemblies are loaded
zacharycmontoya
added
type:bug
area:automatic-instrumentation
kevingosse
approved these changes
Aug 21, 2020
lucaspimentel
approved these changes
Aug 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Today we still have an issue in the automatic instrumentation of
StackExchange.Redis.RedisBase.ExecuteAsync. The first time this method is executed, the type of the object instance is saved and cached for speedup purposes. Unfortunately, this leads to errors when bothStackExchange.RedisandStackExchange.Redis.StrongNamelibraries are brought into the app because they can both enter this integration method but the types are not identical because they are defined in separate assemblies.Changes
StackExchange.Redis.RedisBase.ExecuteAsyncmethod replacement to always perform a type lookup on the instance objectStackExchange.RedisandStackExchange.Redis.StrongNamelibraries are used@DataDog/apm-dotnet