Update DirectSubmissionLogSink tests to be less flaky#8714
Merged
Conversation
Contributor
|
BenchmarksBenchmark execution time: 2026-05-29 21:10:17 Comparing candidate commit 97b244d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 59 known flaky benchmarks, 67 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8714) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (74ms) : 70, 78
master - mean (75ms) : 71, 79
section Bailout
This PR (8714) - mean (78ms) : 76, 80
master - mean (77ms) : 76, 79
section CallTarget+Inlining+NGEN
This PR (8714) - mean (1,116ms) : 1058, 1174
master - mean (1,111ms) : 1054, 1169
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (115ms) : 110, 119
master - mean (116ms) : 111, 121
section Bailout
This PR (8714) - mean (116ms) : 113, 120
master - mean (115ms) : 111, 119
section CallTarget+Inlining+NGEN
This PR (8714) - mean (795ms) : 769, 820
master - mean (795ms) : 772, 818
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (104ms) : 98, 110
master - mean (105ms) : 99, 111
section Bailout
This PR (8714) - mean (105ms) : 101, 109
master - mean (105ms) : 100, 110
section CallTarget+Inlining+NGEN
This PR (8714) - mean (960ms) : 913, 1008
master - mean (960ms) : 918, 1002
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (100ms) : 97, 103
master - mean (101ms) : 96, 106
section Bailout
This PR (8714) - mean (105ms) : 100, 111
master - mean (105ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8714) - mean (829ms) : 791, 866
master - mean (822ms) : 785, 858
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (198ms) : 192, 203
master - mean (199ms) : 191, 207
section Bailout
This PR (8714) - mean (201ms) : 195, 206
master - mean (201ms) : 195, 207
section CallTarget+Inlining+NGEN
This PR (8714) - mean (1,194ms) : 1154, 1234
master - mean (1,197ms) : 1158, 1236
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (284ms) : 278, 291
master - mean (286ms) : 279, 294
section Bailout
This PR (8714) - mean (287ms) : 280, 294
master - mean (286ms) : 279, 294
section CallTarget+Inlining+NGEN
This PR (8714) - mean (961ms) : 941, 981
master - mean (961ms) : 943, 980
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (279ms) : 273, 284
master - mean (278ms) : 270, 287
section Bailout
This PR (8714) - mean (279ms) : 272, 285
master - mean (278ms) : 273, 284
section CallTarget+Inlining+NGEN
This PR (8714) - mean (1,160ms) : 1120, 1200
master - mean (1,155ms) : 1110, 1200
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8714) - mean (277ms) : 269, 285
master - mean (278ms) : 271, 286
section Bailout
This PR (8714) - mean (278ms) : 270, 287
master - mean (279ms) : 272, 285
section CallTarget+Inlining+NGEN
This PR (8714) - mean (1,039ms) : 1012, 1067
master - mean (1,038ms) : 995, 1080
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NachoEchevarria
approved these changes
Jun 2, 2026
andrewlock
added a commit
that referenced
this pull request
Jun 2, 2026
## Summary of changes Refactor the `OtlpSubmissionLogSink` and `OtlpSinkTests` to remove flake ## Reason for change The tests are currently flaky, and there was some recent changes to work on this in #8696 ## Implementation details Basically the same as #8696 and #8714 - don't start the background job, and just call the methods directly ## Test coverage Same coverage, now with less flake 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Refactor the
DirectSubmissionLogSinkandDatadogSinkTeststo remove flakeReason for change
The tests are currently flaky, and there was some recent changes to work on this in #8696
Implementation details
Basically the same as #8696 - don't start the background job, and just call the methods directly
Test coverage
Same coverage, now with less flake 🤞