Update launchSettings.json files: monitoring-home path#8681
Merged
Conversation
Contributor
|
BenchmarksBenchmark execution time: 2026-06-01 16:48:46 Comparing candidate commit 4e57b1a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 26, 2026 09:02
f03168d to
23970e8
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 26, 2026 09:02
b42d454 to
a751b2e
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8681) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (75ms) : 71, 78
master - mean (73ms) : 70, 77
section Bailout
This PR (8681) - mean (77ms) : 75, 79
master - mean (77ms) : 75, 80
section CallTarget+Inlining+NGEN
This PR (8681) - mean (1,114ms) : 1049, 1180
master - mean (1,116ms) : 1065, 1168
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (114ms) : 111, 117
master - mean (113ms) : 109, 117
section Bailout
This PR (8681) - mean (116ms) : 112, 121
master - mean (117ms) : 110, 124
section CallTarget+Inlining+NGEN
This PR (8681) - mean (798ms) : 778, 819
master - mean (793ms) : 770, 817
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (102ms) : 99, 105
master - mean (103ms) : 98, 108
section Bailout
This PR (8681) - mean (105ms) : 100, 110
master - mean (104ms) : 100, 108
section CallTarget+Inlining+NGEN
This PR (8681) - mean (949ms) : 913, 985
master - mean (952ms) : 908, 995
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (100ms) : 95, 104
master - mean (100ms) : 96, 104
section Bailout
This PR (8681) - mean (101ms) : 98, 103
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8681) - mean (827ms) : 796, 858
master - mean (825ms) : 792, 858
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (199ms) : 192, 206
master - mean (200ms) : 195, 204
section Bailout
This PR (8681) - mean (203ms) : 197, 208
master - mean (203ms) : 199, 207
section CallTarget+Inlining+NGEN
This PR (8681) - mean (1,196ms) : 1158, 1233
master - mean (1,206ms) : 1164, 1247
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (285ms) : 278, 292
master - mean (286ms) : 280, 293
section Bailout
This PR (8681) - mean (287ms) : 281, 293
master - mean (288ms) : 282, 293
section CallTarget+Inlining+NGEN
This PR (8681) - mean (961ms) : 938, 983
master - mean (966ms) : 948, 984
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (276ms) : 265, 287
master - mean (276ms) : 269, 283
section Bailout
This PR (8681) - mean (277ms) : 268, 287
master - mean (277ms) : 270, 284
section CallTarget+Inlining+NGEN
This PR (8681) - mean (1,155ms) : 1118, 1192
master - mean (1,161ms) : 1125, 1198
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8681) - mean (277ms) : 271, 283
master - mean (277ms) : 268, 286
section Bailout
This PR (8681) - mean (276ms) : 268, 284
master - mean (277ms) : 267, 287
section CallTarget+Inlining+NGEN
This PR (8681) - mean (1,043ms) : 1006, 1079
master - mean (1,042ms) : 1003, 1081
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 26, 2026 11:26
23970e8 to
c227d31
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 26, 2026 11:26
a751b2e to
5fd41cf
Compare
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 26, 2026 15:46
c227d31 to
8133c26
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 26, 2026 15:46
5fd41cf to
4a3e2d2
Compare
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 27, 2026 09:26
8133c26 to
bf8bd5e
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 27, 2026 09:26
4a3e2d2 to
f76c2be
Compare
andrewlock
added
the
area:builds
andrewlock
marked this pull request as ready for review
May 27, 2026 15:41
andrewlock
requested review from
duncanpharvey,
jchrostek-dd,
link04 and
vandonr
and removed request for
a team
May 27, 2026 15:41
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f76c2bedc1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+8
to
+10
| "CORECLR_PROFILER_PATH": "$(SolutionDir)artifacts\\monitoring-home\\tracer\\win-$(Platform)\\Datadog.Trace.ClrProfiler.Native.dll", | ||
|
|
||
| "DD_DOTNET_TRACER_HOME": "$(SolutionDir)shared\\bin\\monitoring-home\\tracer", | ||
| "DD_DOTNET_TRACER_HOME": "$(SolutionDir)artifacts\\monitoring-home\\tracer", |
There was a problem hiding this comment.
These launch profiles still append \tracer after moving to artifacts\monitoring-home, but the new monitoring home is published with the native loader directly under artifacts\monitoring-home\win-* and DD_DOTNET_TRACER_HOME set to the monitoring-home root (see AddCommonTracerSettings in tracer/build/_build/BuildVariables.cs). As written, launching these Azure Functions profiles (and the other profiles with the same artifacts\monitoring-home\tracer suffix) points CORECLR_PROFILER_PATH and the tracer home at directories that the build no longer creates, so local debugging starts without instrumentation.
Useful? React with 👍 / 👎.
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 28, 2026 16:12
bf8bd5e to
d733886
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 28, 2026 16:13
f76c2be to
a4b708a
Compare
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 29, 2026 09:16
d733886 to
e39d93a
Compare
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
May 29, 2026 09:16
a4b708a to
7a54b7e
Compare
NachoEchevarria
approved these changes
May 29, 2026
bouwkast
approved these changes
May 29, 2026
bouwkast
left a comment
bouwkast
left a comment
Collaborator
There was a problem hiding this comment.
didn't do a deep review but 👍
andrewlock
force-pushed
the
andrew/more-artifacts-output
branch
from
May 29, 2026 21:00
e39d93a to
70253f0
Compare
Replace stale $(SolutionDir)shared/bin/monitoring-home references with $(SolutionDir)artifacts/monitoring-home across all sample-app Properties/launchSettings.json files. These files are developer convenience for running samples from VS/Rider — they don't affect CI, hence kept separate from the fixup commits. Co-Authored-By: Claude Opus 4.7 <[email protected]>
andrewlock
force-pushed
the
andrew/update-launchsettings.json
branch
from
June 1, 2026 15:55
2ac8acd to
4e57b1a
Compare
andrewlock
enabled auto-merge (squash)
June 1, 2026 15:55
andrewlock
disabled auto-merge
June 1, 2026 19:39
NachoEchevarria
added a commit
that referenced
this pull request
Jun 2, 2026
…path (#8726) @ ## Summary of changes Change `SLS_CI_BRANCH` in `.gitlab-ci.yml` from the `v1.3.0` tag to `main` for the `benchmark-serverless-trigger` downstream pipeline. ## Reason for change The serverless benchmark trigger pins `serverless-tools` to tag `v1.3.0`, whose `.gitlab/setup.sh` copies the tracer home from the old `./shared/bin/monitoring-home` location. That output was relocated to `./artifacts/monitoring-home` (#8681), so the downstream job fails with `cp: cannot stat ./shared/bin/monitoring-home: No such file or directory` even though the tracer build succeeds. `serverless-tools` already fixed this on `main` (commit `110e5dd`, "Fix path used by .NET artifacts"), but no tag containing the fix has been released yet — `v1.3.0` is still the latest tag. ## Implementation details `SLS_CI_BRANCH: v1.3.0` → `SLS_CI_BRANCH: main`.⚠️ **Temporary:** this tracks `serverless-tools` tip rather than a pinned release. Once `serverless-tools` cuts a new tag (e.g. `v1.3.1`) that includes the fix, this should be pointed back at that tag. ## Test coverage ## Other details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update all the launchsettings.json to point to the new output path in #8680
Reason for change
We moved the default output folder in #8680, but there were already enough changes in that PR, so I didn't want to clutter it up with these simple changes.
Implementation details
🤖 converted
shared\bintoartifactsTest coverage
N/A - it's only for local testing (personally I would probably remove all of these files completely, but some people like them)
Other details
Stacked on
Datadog.Trace.Build.g.slnto reduce size of artifacts copied between stages #8610ArtifactsOutputin more places in the tracer build #8636