[DBM] Skip telemetry for DBM errors#8679
Merged
Merged
Conversation
github-actions
Bot
added
the
area:tracer
BenchmarksBenchmark execution time: 2026-06-16 13:42:18 Comparing candidate commit 98f5ae0 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 70 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8679) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (73ms) : 70, 75
master - mean (73ms) : 70, 75
section Bailout
This PR (8679) - mean (79ms) : 74, 83
master - mean (78ms) : 74, 81
section CallTarget+Inlining+NGEN
This PR (8679) - mean (1,109ms) : 1052, 1166
master - mean (1,110ms) : 1067, 1153
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (116ms) : 111, 121
master - mean (115ms) : 110, 119
section Bailout
This PR (8679) - mean (118ms) : 112, 123
master - mean (119ms) : 113, 125
section CallTarget+Inlining+NGEN
This PR (8679) - mean (794ms) : 767, 821
master - mean (796ms) : 771, 821
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (105ms) : 100, 111
master - mean (101ms) : 98, 105
section Bailout
This PR (8679) - mean (103ms) : 100, 107
master - mean (106ms) : 101, 112
section CallTarget+Inlining+NGEN
This PR (8679) - mean (950ms) : 902, 998
master - mean (947ms) : 905, 989
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (101ms) : 96, 106
master - mean (100ms) : 96, 104
section Bailout
This PR (8679) - mean (105ms) : 99, 111
master - mean (101ms) : 98, 103
section CallTarget+Inlining+NGEN
This PR (8679) - mean (827ms) : 782, 872
master - mean (829ms) : 789, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (198ms) : 190, 205
master - mean (198ms) : 192, 205
section Bailout
This PR (8679) - mean (200ms) : 195, 205
master - mean (201ms) : 197, 205
section CallTarget+Inlining+NGEN
This PR (8679) - mean (1,194ms) : 1153, 1235
master - mean (1,187ms) : 1132, 1241
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (285ms) : 277, 292
master - mean (284ms) : 276, 293
section Bailout
This PR (8679) - mean (284ms) : 278, 290
master - mean (284ms) : 278, 290
section CallTarget+Inlining+NGEN
This PR (8679) - mean (956ms) : 932, 981
master - mean (957ms) : 939, 975
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (278ms) : 270, 286
master - mean (276ms) : 270, 281
section Bailout
This PR (8679) - mean (277ms) : 271, 283
master - mean (276ms) : 270, 282
section CallTarget+Inlining+NGEN
This PR (8679) - mean (1,157ms) : 1121, 1193
master - mean (1,156ms) : 1114, 1199
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8679) - mean (275ms) : 269, 282
master - mean (277ms) : 268, 285
section Bailout
This PR (8679) - mean (275ms) : 269, 282
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (8679) - mean (1,036ms) : 1001, 1071
master - mean (1,037ms) : 988, 1087
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
link04
approved these changes
May 22, 2026
bouwkast
reviewed
Jun 9, 2026
| // when it's private _socket field is set to null by a prior network error, | ||
| // without it being set in ConnectionState. This is an internal SqlClient | ||
| // race condition that we (and customer) can't act on, so suppress telemetry. | ||
| const string messageTemplate = "Error setting context_info [{ContextValue}] for DB query, falling back to service only propagation mode. There won't be any link with APM traces. (will log this error {N} more time and then stop)"; |
Collaborator
There was a problem hiding this comment.
FWIW, probably worth checking / verifying but I think all of the currently remaining errors for DBM propagation here are really things out of our control so I wonder if we can just send everything to ErrorSkipTelemetry
Member
Author
There was a problem hiding this comment.
Yeah, agreed, switched as you suggested
andrewlock
force-pushed
the
andrew/null-in-dbm
branch
from
June 9, 2026 08:14
5dbf486 to
8983424
Compare
andrewlock
changed the title
andrewlock
marked this pull request as ready for review
June 9, 2026 08:18
This comment has been minimized.
This comment has been minimized.
andrewlock
force-pushed
the
andrew/null-in-dbm
branch
from
June 11, 2026 20:52
af3b310 to
015be4a
Compare
andrewlock
enabled auto-merge (squash)
June 11, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Skips telemetry for errors when executing a command with DBM
Reason for change
We're making a "real" SQL request, so it could fail for all sorts of reasons
Implementation details
Suppress the errors - there's too much noise.
Test coverage
Meh
Other details
Fixes this error - among others