Skip to content

[Crashtracker] Do not redact frames in crashtracker#8675

Merged
gleocadie merged 3 commits into
masterfrom
gleocadie/do-not-redact-callstack-at-crash-time
Jun 5, 2026
Merged

[Crashtracker] Do not redact frames in crashtracker#8675
gleocadie merged 3 commits into
masterfrom
gleocadie/do-not-redact-callstack-at-crash-time

Conversation

@gleocadie

@gleocadie gleocadie commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Do not redact managed frames in crash reports.

Reason for change

There 2 aspects:

  • Security review agreed that callstacks are not considered as PII and can be sent without any redaction mechanism
  • Customers can use crash reports from the ErrorTracking UI and redacted frames will prevent them on acting on the crashes.

Implementation details

  • Remove method ShouldRedactFrame and the call to it.

Test coverage

Other details

@gleocadie
gleocadie requested a review from a team as a code owner May 22, 2026 10:42
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@pr-commenter

pr-commenter Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-05 09:13:50

Comparing candidate commit 97861d3 in PR branch gleocadie/do-not-redact-callstack-at-crash-time with baseline commit 44f05b7 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 57 known flaky benchmarks, 69 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-6573.775op/s; -6150.500op/s] or [-7.504%; -7.021%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-7576.869op/s; -7043.488op/s] or [-8.984%; -8.351%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-7341.251op/s; -5782.688op/s] or [-7.464%; -5.880%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+310.947ms; +318.195ms] or [+154.303%; +157.900%]
  • 🟥 throughput [-43.172op/s; -39.272op/s] or [-7.767%; -7.066%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+379.342ms; +381.986ms] or [+299.704%; +301.792%]
  • 🟩 throughput [+91.071op/s; +95.504op/s] or [+12.007%; +12.592%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+389.946ms; +392.005ms] or [+345.088%; +346.910%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-16.144ms; -11.960ms] or [-7.540%; -5.586%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-268261.377op/s; -265412.392op/s] or [-27.391%; -27.100%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.402ms; -21.561ms] or [-11.774%; -9.615%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-145508.674op/s; -129617.689op/s] or [-20.907%; -18.624%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+9139.849op/s; +11795.624op/s] or [+7.281%; +9.397%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+424904.097op/s; +451269.884op/s] or [+14.168%; +15.047%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.884ms; -14.552ms] or [-8.705%; -6.708%]
  • 🟩 throughput [+152785.818op/s; +212390.571op/s] or [+6.064%; +8.430%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.654ms; +300.400ms] or [+149.727%; +150.100%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+297.385ms; +311.505ms] or [+149.972%; +157.093%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.326ms; +304.465ms] or [+151.281%; +153.366%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+295.904ms; +296.714ms] or [+145.336%; +145.734%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+294.373ms; +298.842ms] or [+143.908%; +146.093%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+302.273ms; +304.326ms] or [+151.076%; +152.102%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+22.647µs; +46.290µs] or [+7.230%; +14.778%]
  • 🟥 throughput [-430.913op/s; -231.975op/s] or [-13.433%; -7.231%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.186ms; +299.967ms] or [+149.325%; +149.715%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+322.007ms; +392.718ms] or [+349.873%; +426.705%]
  • 🟩 throughput [+767.232op/s; +946.184op/s] or [+6.304%; +7.775%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+242.769ms; +308.700ms] or [+184.332%; +234.393%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+319.135ms; +391.569ms] or [+146.735%; +180.040%]
  • 🟥 throughput [-565.384op/s; -510.368op/s] or [-51.229%; -46.244%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+149.031ms; +294.640ms] or [+63.511%; +125.563%]
  • 🟥 throughput [-674.558op/s; -590.765op/s] or [-44.993%; -39.404%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+349.586ms; +360.596ms] or [+209.093%; +215.678%]
  • 🟥 throughput [-436.897op/s; -399.158op/s] or [-30.421%; -27.793%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-144.435µs; -105.119µs] or [-7.317%; -5.325%]
  • 🟩 throughput [+29.887op/s; +39.808op/s] or [+5.900%; +7.858%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.466ms; +304.101ms] or [+152.316%; +153.139%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+304.271ms; +305.862ms] or [+152.471%; +153.268%]
  • 🟩 throughput [+33296.701op/s; +39572.072op/s] or [+5.250%; +6.239%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.388ms; +305.185ms] or [+151.405%; +153.312%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.765ms; +306.379ms] or [+152.540%; +153.853%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+295.363ms; +298.021ms] or [+146.044%; +147.358%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+303.222ms; +306.961ms] or [+153.686%; +155.581%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.238ms; +301.835ms] or [+150.692%; +151.494%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+301.795ms; +304.243ms] or [+150.417%; +151.637%]
  • 🟩 throughput [+43686.160op/s; +52857.988op/s] or [+8.675%; +10.496%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+301.398ms; +304.276ms] or [+149.943%; +151.375%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.419ms; -12.760ms] or [-7.635%; -5.933%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+15.550µs; +60.837µs] or [+3.841%; +15.027%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.811KB; -19.788KB] or [-7.227%; -7.218%]
  • unstable execution_time [-35.185µs; +23.600µs] or [-6.954%; +4.664%]
  • unstable throughput [-79.738op/s; +128.206op/s] or [-3.979%; +6.398%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-53.157µs; +9.228µs] or [-9.212%; +1.599%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+7.171µs; +12.216µs] or [+16.950%; +28.874%]
  • 🟥 throughput [-5257.729op/s; -3281.203op/s] or [-22.133%; -13.813%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.103µs; -4.603µs] or [-20.328%; -7.142%]
  • unstable throughput [+1181.722op/s; +3003.974op/s] or [+7.250%; +18.430%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.828ms; +302.267ms] or [+152.055%; +152.782%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+305.847ms; +309.045ms] or [+155.675%; +157.303%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+298.522ms; +301.579ms] or [+149.447%; +150.978%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+298.412ms; +300.659ms] or [+148.731%; +149.851%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.896ms; +303.813ms] or [+151.598%; +152.560%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.280ms; +304.901ms] or [+153.297%; +154.626%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.913ms; +300.856ms] or [+149.598%; +150.069%]
  • 🟩 throughput [+61145231.904op/s; +61421824.259op/s] or [+44.530%; +44.731%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+419.957ms; +424.184ms] or [+522.291%; +527.548%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.144ms; +300.338ms] or [+149.206%; +149.802%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+87692.891op/s; +94932.110op/s] or [+8.188%; +8.864%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+74230.847op/s; +85538.320op/s] or [+7.372%; +8.495%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+52608.515op/s; +59181.663op/s] or [+9.553%; +10.746%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+23274.492op/s; +32877.738op/s] or [+5.210%; +7.359%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+95882.040op/s; +112380.978op/s] or [+10.712%; +12.556%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@gleocadie
gleocadie requested a review from a team as a code owner May 22, 2026 12:36
@gleocadie
gleocadie requested a review from vandonr May 22, 2026 12:36
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8675) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.26 ± (73.36 - 73.88) ms74.82 ± (74.74 - 75.26) ms+2.1%✅⬆️
.NET Framework 4.8 - Bailout
duration77.01 ± (76.89 - 77.32) ms78.06 ± (77.94 - 78.34) ms+1.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1099.80 ± (1099.16 - 1106.94) ms1106.16 ± (1106.30 - 1113.94) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.55 ± (22.51 - 22.59) ms22.46 ± (22.41 - 22.51) ms-0.4%✅
process.time_to_main_ms83.87 ± (83.64 - 84.10) ms84.22 ± (83.99 - 84.45) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.93 ± (10.92 - 10.93) MB10.93 ± (10.93 - 10.93) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.24 ± (22.20 - 22.28) ms22.31 ± (22.27 - 22.35) ms+0.3%✅⬆️
process.time_to_main_ms84.34 ± (84.17 - 84.52) ms85.26 ± (85.05 - 85.48) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.96 ± (10.96 - 10.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms214.26 ± (213.34 - 215.18) ms214.42 ± (213.36 - 215.47) ms+0.1%✅⬆️
process.time_to_main_ms541.56 ± (540.05 - 543.07) ms543.18 ± (541.63 - 544.74) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.35 ± (48.32 - 48.38) MB48.24 ± (48.19 - 48.28) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms21.31 ± (21.27 - 21.34) ms21.20 ± (21.16 - 21.25) ms-0.5%✅
process.time_to_main_ms73.41 ± (73.25 - 73.57) ms73.53 ± (73.35 - 73.70) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.63) MB10.64 ± (10.64 - 10.65) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.58 ± (21.52 - 21.64) ms21.42 ± (21.36 - 21.49) ms-0.7%✅
process.time_to_main_ms76.45 ± (76.17 - 76.73) ms76.52 ± (76.20 - 76.83) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.74 ± (10.74 - 10.75) MB10.76 ± (10.76 - 10.77) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms369.29 ± (367.35 - 371.23) ms370.81 ± (368.51 - 373.11) ms+0.4%✅⬆️
process.time_to_main_ms546.22 ± (544.83 - 547.61) ms547.90 ± (546.73 - 549.06) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.78 ± (49.76 - 49.81) MB49.79 ± (49.77 - 49.82) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.33 ± (19.28 - 19.38) ms19.36 ± (19.32 - 19.39) ms+0.2%✅⬆️
process.time_to_main_ms72.26 ± (72.04 - 72.49) ms72.33 ± (72.12 - 72.53) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.68) MB7.68 ± (7.67 - 7.68) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.24 ± (19.20 - 19.29) ms19.28 ± (19.25 - 19.32) ms+0.2%✅⬆️
process.time_to_main_ms72.89 ± (72.71 - 73.07) ms72.68 ± (72.51 - 72.85) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.73) MB7.73 ± (7.72 - 7.73) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms294.59 ± (292.68 - 296.51) ms296.91 ± (295.03 - 298.79) ms+0.8%✅⬆️
process.time_to_main_ms495.72 ± (494.72 - 496.72) ms495.07 ± (493.98 - 496.16) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.91 ± (36.89 - 36.94) MB36.90 ± (36.87 - 36.93) MB-0.0%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration198.96 ± (198.86 - 199.90) ms199.17 ± (198.69 - 199.71) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration203.34 ± (203.05 - 204.08) ms201.90 ± (201.34 - 202.12) ms-0.7%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1197.24 ± (1196.44 - 1201.88) ms1197.32 ± (1196.85 - 1202.52) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms194.59 ± (194.08 - 195.09) ms192.38 ± (192.03 - 192.74) ms-1.1%✅
process.time_to_main_ms84.49 ± (84.20 - 84.77) ms84.06 ± (83.77 - 84.35) ms-0.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.03 ± (16.01 - 16.05) MB16.16 ± (16.13 - 16.19) MB+0.8%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms195.43 ± (194.94 - 195.92) ms193.09 ± (192.63 - 193.55) ms-1.2%✅
process.time_to_main_ms86.00 ± (85.74 - 86.25) ms85.82 ± (85.57 - 86.08) ms-0.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.08 - 16.12) MB16.11 ± (16.08 - 16.14) MB+0.0%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms387.57 ± (386.29 - 388.84) ms389.23 ± (388.22 - 390.25) ms+0.4%✅⬆️
process.time_to_main_ms537.62 ± (536.39 - 538.85) ms540.23 ± (539.35 - 541.10) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.66 ± (57.43 - 57.88) MB58.05 ± (57.82 - 58.28) MB+0.7%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms197.78 ± (197.36 - 198.21) ms197.91 ± (197.50 - 198.31) ms+0.1%✅⬆️
process.time_to_main_ms72.65 ± (72.35 - 72.95) ms73.14 ± (72.85 - 73.44) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.36 ± (16.33 - 16.38) MB16.40 ± (16.37 - 16.42) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms197.99 ± (197.59 - 198.38) ms196.60 ± (196.10 - 197.09) ms-0.7%✅
process.time_to_main_ms73.81 ± (73.60 - 74.02) ms73.72 ± (73.46 - 73.98) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.38 ± (16.35 - 16.42) MB16.41 ± (16.38 - 16.44) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms587.38 ± (584.71 - 590.05) ms587.15 ± (584.58 - 589.72) ms-0.0%✅
process.time_to_main_ms540.74 ± (539.85 - 541.63) ms540.25 ± (539.25 - 541.26) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.15 ± (61.07 - 61.24) MB61.20 ± (61.10 - 61.30) MB+0.1%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.3%✅
.NET 8 - Baseline
process.internal_duration_ms195.33 ± (194.96 - 195.70) ms194.78 ± (194.34 - 195.23) ms-0.3%✅
process.time_to_main_ms72.29 ± (71.97 - 72.61) ms71.90 ± (71.62 - 72.19) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.74 ± (11.72 - 11.76) MB11.78 ± (11.75 - 11.80) MB+0.4%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms193.87 ± (193.38 - 194.36) ms193.70 ± (193.27 - 194.13) ms-0.1%✅
process.time_to_main_ms72.84 ± (72.59 - 73.08) ms72.54 ± (72.32 - 72.76) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.80 - 11.84) MB11.81 ± (11.78 - 11.84) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.6%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms517.05 ± (514.59 - 519.50) ms516.10 ± (513.77 - 518.43) ms-0.2%✅
process.time_to_main_ms490.25 ± (489.57 - 490.92) ms490.08 ± (489.25 - 490.92) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.58 ± (50.54 - 50.62) MB50.64 ± (50.60 - 50.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 29)-1.0%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (75ms)  : 71, 79
    master - mean (74ms)  : 70, 78

    section Bailout
    This PR (8675) - mean (78ms)  : 75, 81
    master - mean (77ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (1,110ms)  : 1056, 1164
    master - mean (1,103ms)  : 1045, 1161
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (113ms)  : 109, 118
    master - mean (113ms)  : 108, 118

    section Bailout
    This PR (8675) - mean (114ms)  : 111, 117
    master - mean (113ms)  : 110, 117

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (794ms)  : 769, 818
    master - mean (792ms)  : 764, 820
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (101ms)  : 98, 105
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (8675) - mean (104ms)  : 100, 109
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (947ms)  : 910, 985
    master - mean (947ms)  : 908, 985
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (99ms)  : 95, 103
    master - mean (99ms)  : 95, 104

    section Bailout
    This PR (8675) - mean (99ms)  : 97, 102
    master - mean (100ms)  : 97, 103

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (821ms)  : 791, 851
    master - mean (819ms)  : 780, 857
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (199ms)  : 193, 205
    master - mean (199ms)  : 193, 206

    section Bailout
    This PR (8675) - mean (202ms)  : 198, 206
    master - mean (204ms)  : 198, 209

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (1,200ms)  : 1159, 1240
    master - mean (1,199ms)  : 1162, 1236
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (285ms)  : 280, 291
    master - mean (288ms)  : 277, 299

    section Bailout
    This PR (8675) - mean (288ms)  : 281, 294
    master - mean (290ms)  : 280, 300

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (968ms)  : 948, 987
    master - mean (964ms)  : 943, 986
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (280ms)  : 273, 286
    master - mean (280ms)  : 274, 285

    section Bailout
    This PR (8675) - mean (279ms)  : 273, 285
    master - mean (280ms)  : 275, 286

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (1,161ms)  : 1130, 1192
    master - mean (1,158ms)  : 1122, 1194
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8675) - mean (276ms)  : 269, 284
    master - mean (278ms)  : 272, 283

    section Bailout
    This PR (8675) - mean (276ms)  : 270, 282
    master - mean (277ms)  : 270, 283

    section CallTarget+Inlining+NGEN
    This PR (8675) - mean (1,039ms)  : 997, 1080
    master - mean (1,039ms)  : 1004, 1075
Loading

@gleocadie
gleocadie force-pushed the gleocadie/do-not-redact-callstack-at-crash-time branch from e6842cd to b9d764c Compare June 3, 2026 10:02
@gleocadie
gleocadie force-pushed the gleocadie/do-not-redact-callstack-at-crash-time branch 3 times, most recently from f9e61af to 3930b08 Compare June 4, 2026 13:21
@gleocadie
gleocadie requested a review from a team as a code owner June 4, 2026 13:21
@gleocadie
gleocadie force-pushed the gleocadie/do-not-redact-callstack-at-crash-time branch from 3930b08 to 1b8aed3 Compare June 4, 2026 15:13
andrewlock
andrewlock approved these changes Jun 5, 2026
View reviewed changes
Comment thread tracer/test/Datadog.Trace.Tools.dd_dotnet.ArtifactTests/CreatedumpTests.cs
@gleocadie
gleocadie merged commit 97e7355 into master Jun 5, 2026
137 checks passed
@gleocadie
gleocadie deleted the gleocadie/do-not-redact-callstack-at-crash-time branch June 5, 2026 09:43
@github-actions github-actions Bot added this to the vNext-v3 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@vandonr vandonr Awaiting requested review from vandonr vandonr is a code owner automatically assigned from DataDog/apm-idm-dotnet

Assignees

No one assigned

Labels

area:crashtracking

Projects

None yet

Milestone

3.46.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gleocadie @andrewlock